Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtree-push nightly-2024-04-08 #7

Closed

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Apr 8, 2024

Bumping the toolchain version as part of a git subtree push

current toolchain (nightly-2023-12-28):

  • 1.77.0-nightly (89e2160c4 2023-12-27)

latest toolchain (nightly-2024-04-08):

  • 1.79.0-nightly (9d5cdf75a 2024-04-07)

Copy link
Author

github-actions bot commented Apr 8, 2024

There was an issue and this subtree-push can't automatically be merged ⚠️

  1. Please checkout branch subtree-push-nightly-2024-04-08, fix any merge conflicts, and then run git merge upstream/subtree_push_automation --no-ff
  2. Bump the toolchain listed in the rust-toolchain file to nightly-2024-04-08, and commit those changes.
  3. Run the Diff-Check Job.
  4. Wait for CI checks to pass.

We need to allow `StyleEditionDefault` because it will be used to
implement `style_edition`, and we didn't need to explicitly import it
for tests since it's already imported by `use super::*;`.
fixes compilation issues with the `generic-simd` feature
Can't run `cargo test --all` for `error-chain` anymore. The tests don't
compile because of `#[deny(invalid_doc_attributes)]`. Here's  the error
message:

```
error: this attribute can only be applied at the crate level
   --> tests/tests.rs:508:7
    |
508 | #[doc(test)]
    |       ^^^^
    |
    = note: read <https://doc.rust-lang.org/nightly/rustdoc/the-doc-attribute.html#at-the-crate-level> for more information
    = note: `#[deny(invalid_doc_attributes)]` on by default
help: to apply to the crate, use an inner attribute
    |
508 | #![doc(test)]
    |  +
```
@ytmimi ytmimi force-pushed the subtree-push-nightly-2024-04-08 branch 2 times, most recently from 41778bd to 44a0dae Compare May 6, 2024 17:38
The syntax changed from `expr: ty` -> `builtin # type_ascribe(expr, ty)`
For now, rustfmt will just emit the contents of the span.
@ytmimi ytmimi force-pushed the subtree-push-nightly-2024-04-08 branch from 44a0dae to 35ad744 Compare May 6, 2024 18:07
@ytmimi ytmimi closed this Jun 25, 2024
@ytmimi ytmimi deleted the subtree-push-nightly-2024-04-08 branch June 25, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant