forked from openframeworks/openFrameworks
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update openframeworks #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offending files found via: $ find . -type f -name '*.h' -o -name '*.cpp' -o -name '*.mm' -o -name '*.m' -exec grep -l "NSAutoreleasePool" {} \; While it would appear as though a lot of code has changed, really it is largely due to an extra level of indentation required by @autoreleasepool. Additionally, all lines touched should be normalized to use tabs instead of spaces - I'm not a fan of tabs, but I'd rather be consistent than not. One API change made in ofSystemAlertDialog() to migrate off a mega deprecated NSAlert API. One file was updated that targets iOS, seemingly missed in #2888.
when using glDrawElements the index buffer never gets bound. By adding it to the bind method it gets added to the VAO state when VAO is used or bound when not. To test use a VBO and and a mesh with setMesh and draw with drawElements
solved issue with glDrawElements
Removed unused variables from ofVbo
…o bugfix-gstmemleaks
…o bugfix-Makefile-project-source-paths-with-spaces-v2
incremented index in ofTrueTypeFont::getStringBoundingBox
Update String Functions, Include UTF-8 Support
Apothecary core
unloadSound() did not previously close file descriptors which would eventually lead to a crash when too many file descriptors where open (about 1000 for Raspberry Pi). OpenAL sources must be deleted before buffers otherwise it will result in **Illegal Operation**.
Close file descriptors and fix OpenAL issue
use iterators instead of deprecated ofBuffer line methods
Added thread locking, fixed getPosition, setPosition, unloadSound and proper OpenAL error fetching.
adds support for 16 bit GL channels to ofGLUtils
fix deprecation warning in ofShader
ofBuffer: remove unimplemented method
Fixed numerous issues and added locking
add half float gl type support to ofGLUtils
adds some missing integer / unsigned integer formats, half-float data types
adds some missing image types to ofGLUtils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave a comment