-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dbt 1.8 #75
Support dbt 1.8 #75
Conversation
Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
WalkthroughThe recent updates to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (4)
dbt_artifacts_parser/resources/manifest/manifest_v12.json
is excluded by!**/*.json
dbt_artifacts_parser/resources/run-results/run-results_v6.json
is excluded by!**/*.json
tests/resources/v12/jaffle_shop/manifest.json
is excluded by!**/*.json
tests/resources/v6/jaffle_shop/run_results.json
is excluded by!**/*.json
Files selected for processing (6)
- dbt_artifacts_parser/parser.py (6 hunks)
- dbt_artifacts_parser/parsers/manifest/manifest_v11.py (1 hunks)
- dbt_artifacts_parser/parsers/run_results/run_results_v6.py (1 hunks)
- dbt_artifacts_parser/parsers/version_map.py (2 hunks)
- dev/generate_parser_classes.sh (2 hunks)
- tests/test_parser.py (2 hunks)
Files skipped from review due to trivial changes (3)
- dbt_artifacts_parser/parsers/manifest/manifest_v11.py
- dev/generate_parser_classes.sh
- tests/test_parser.py
Additional comments not posted (4)
dbt_artifacts_parser/parsers/run_results/run_results_v6.py (1)
72-79
: The structure and implementation ofRunResultsV6
look good and are well-suited for the intended purpose.dbt_artifacts_parser/parsers/version_map.py (1)
Line range hint
34-102
: The updates to the version map to includeManifestV12
andRunResultsV6
are correctly implemented with appropriate schema URLs and class references.dbt_artifacts_parser/parser.py (2)
31-37
: The updated import statements to includeManifestV12
andRunResultsV6
are correctly implemented.
Line range hint
87-297
: The updates to the parsing functions to handleManifestV12
andRunResultsV6
are correctly implemented and ensure that the new versions are handled appropriately.
class Config: | ||
extra = Extra.forbid | ||
|
||
status: Union[StatusEnum, StatusEnum1, StatusEnum2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider simplifying the use of multiple enums for status
. If distinct statuses are necessary, ensure clear documentation or consider merging them into a single enum with additional states.
dbt_schema_version: str | ||
dbt_version: Optional[str] = '1.8.0a1' | ||
generated_at: Optional[str] = None | ||
invocation_id: Optional[Optional[str]] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider simplifying the type hint for invocation_id
from Optional[Optional[str]]
to Optional[str]
.
No description provided.