Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch fs.watch exceptions #125

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Catch fs.watch exceptions #125

merged 1 commit into from
Jul 14, 2022

Conversation

campersau
Copy link
Contributor

@campersau campersau commented Jul 13, 2022

To test this I relied on the fact the the options are getting copied with Object.assign({}, options, {...}) so that I could delete the directory before fs.watch is called but after the is.directory / is.file checks.

Fixes #108

@yuanchuan
Copy link
Owner

Thank you

@yuanchuan yuanchuan merged commit 5743e51 into yuanchuan:main Jul 14, 2022
@campersau campersau deleted the fswatchex branch July 14, 2022 08:53
campersau added a commit to campersau/node-watch that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch errors when adding watchers for child directories
2 participants