fix: continue fix Obsidian v.15.* #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yuanotes , I find a bug by registering callback often. Obsidian does reuse old editor sometimes, if that case, current code will register callback multiple times and when vim mode changes, the callback will be called multiple times.
If the callback being registered for 50 times, the Obsidian will slow down a lot.
I quickly fix this bug, but I don't suggest to merge the PR right now. Let me test the plugin for like 1 month. I send the PR just to avoid wasting your time in case you are confused by this bug.