Fix server-side rendering #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Are you gonna release this modification to prevent server side rendering errors ? It would really help on halogen ! |
|
This one would be highly appreciated. |
zvictor
reviewed
Mar 20, 2017
| module.exports = document.createElement('div').style; | ||
| var canUseDOM = require('./canUseDOM'); | ||
|
|
||
| module.exports = canUseDOM && document.createElement('div').style; |
There was a problem hiding this comment.
I am having issues with this line of code as it sometimes evaluates to an object, sometimes to a false.
The following should be safer:
module.exports = (canUseDOM && document.createElement('div').style) || {};
|
For posterity - I merged this one here: https://github.com/hdngr/domkit Thanks @yuanyan and @LoicMahieu! |
|
It would be nice to have this implemented. I'm still struggling with server pre-rendering despite a fix being written for it over a year ago. |
|
@yuanyan Curious why this hasn't been merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6
Related:
yuanyan/boron#8
yuanyan/boron#24