Update pot.erl to support sha256 and not use deprecated :crypto.hmac #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuce#29 support sha256
|
This looks reasonable. I would like to wait on #31 to be merged so that you can rebase on it and we can have passing CI record on all supported OTP versions, if that's OK! |
|
sure - happy to rebase once #31 is merged |
|
Well, the broken travis check stopped, but it doesn't seem to trigger the GitHub Action flow. that's really weird! |
nalundgaard
reviewed
Mar 15, 2021
nalundgaard
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29
support sha256