Skip to content

Commit

Permalink
build-aci: Fix ACI image name
Browse files Browse the repository at this point in the history
The appc discovery spec states that the architecture specifier in the ACI
image file name will be an ACI architecture value.  Our build scripts were
using GOARCH in the image name, which is incorrect for arm64/aarch64.
See: https://github.com/appc/spec/blob/master/spec/discovery.md

Fixes errors like these on arm64 machines:

  $ rkt --debug --insecure-options=image fetch coreos.com/etcd:v3.2.0-rc.1
  image: remote fetching from URL "https://github.com/coreos/etcd/releases/download/v3.2.0-rc.1/etcd-v3.2.0-rc.1-linux-aarch64.aci"
  fetch: bad HTTP status code: 404

Signed-off-by: Geoff Levand <geoff@infradead.org>
  • Loading branch information
glevand authored and Iwasaki Yudai committed Oct 5, 2017
1 parent 0672500 commit 05fea12
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions scripts/build-aci
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ fi
acbuild --debug begin

TMPHOSTS="$(mktemp)"
ACI_ARCH="$(go2aci ${GOARCH})"

acbuildEnd() {
rm "$TMPHOSTS"
Expand Down Expand Up @@ -71,7 +72,7 @@ acbuild --debug port add peer tcp 2380

acbuild --debug copy "$TMPHOSTS" /etc/hosts

acbuild --debug label add arch "$(go2aci ${GOARCH})"
acbuild --debug label add arch "${ACI_ARCH}"

# mkdir default data-dir
mkdir -p .acbuild/currentaci/rootfs/var/lib/etcd
Expand All @@ -80,4 +81,4 @@ mkdir -p .acbuild/currentaci/rootfs/var/lib/etcd
ln -s ./usr/local/bin/etcd .acbuild/currentaci/rootfs/etcd
ln -s ./usr/local/bin/etcdctl .acbuild/currentaci/rootfs/etcdctl

acbuild --debug write --overwrite $BUILDDIR/etcd-${1}-linux-${GOARCH}.aci
acbuild --debug write --overwrite $BUILDDIR/etcd-${1}-linux-${ACI_ARCH}.aci

0 comments on commit 05fea12

Please sign in to comment.