[MYSQL] Import schema for auto-generated column fails after Ora2Pg commit

[shubham-yb]

This is the original ticket
#315

So an issue was put up on Ora2Pg and they implemented migration of auto-generated columns using triggers.
Commit

But now the import-schema fails with error.

Original schema:

CREATE TABLE auto_price (
	id INT,
	first_name VARCHAR(50),
	gender VARCHAR(50),
	price_dollar DECIMAL(7,2),
    price_pound DECIMAL(7,2) GENERATED ALWAYS AS (price_dollar * 0.22) STORED
);

Previously exported schema:

CREATE TABLE auto_price (
	id bigint,
	first_name varchar(50),
	gender varchar(50),
	price_dollar decimal(7,2),
	price_pound decimal(7,2)
) ;

Exported schema after commit:

CREATE TABLE auto_price (
	id bigint,
	first_name varchar(50),
	gender varchar(50),
	price_dollar decimal(7,2),
	price_pound decimal(7,2)
) ;
DROP TRIGGER IF EXISTS virt_col_auto_price_trigger ON auto_price CASCADE;

CREATE OR REPLACE FUNCTION fct_virt_col_auto_price_trigger() RETURNS trigger AS $BODY$
BEGIN
	NEW.price_pound = (NEW.price_dollar * 0.22);

RETURN NEW;
end
$BODY$
 LANGUAGE 'plpgsql' SECURITY DEFINER;

CREATE TRIGGER virt_col_auto_price_trigger
        BEFORE INSERT OR UPDATE ON auto_price FOR EACH ROW
        EXECUTE PROCEDURE fct_virt_col_auto_price_trigger();

Error while importing:

importing      TABLE      
    ERROR: unterminated dollar-quoted string at or near "$BODY$ BEGIN 	NEW.price_pound = (NEW.price_dollar * 0.22); " (SQLSTATE 42601)
    STATEMENT: CREATE OR REPLACE FUNCTION fct_virt_col_auto_price_trigger() RETURNS trigger AS $BODY$
BEGIN
	NEW.price_pound = (NEW.price_dollar * 0.22);
ERROR: unterminated dollar-quoted string at or near "$BODY$ BEGIN 	NEW.price_pound = (NEW.price_dollar * 0.22); " (SQLSTATE 42601)

[amit-yb]

@shubham-yb Looks like @sanyamsinghal fixed this issue as part of #399 . Please, verify and close this issue.

[shubham-yb]

@amit-yb @sanyamsinghal I'm still getting the issue.

[sanyamsinghal]

Fix: change the parsing logic to lookahead parsing instead of based on kind of sql file

[sanyamsinghal]

@shubham-yb can you please verify this bug with main branch now. Changes merged in #506