Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1796]Bug Fix: assess-migration failing on PG12 and below for db_queries psql script #1801

Merged
merged 3 commits into from
Oct 25, 2024
Merged

[#1796]Bug Fix: assess-migration failing on PG12 and below for db_queries psql script #1801

merged 3 commits into from
Oct 25, 2024

Conversation

sanyamsinghal
Copy link
Collaborator

  • removing extra columns(not in use) of pgss from db-queries-summary script
  • Fixed checks for REPORT_UNSUPPORTED_QUERY_CONSTRUCTS env var in pg gather metadata script

@sanyamsinghal
Copy link
Collaborator Author

https://jenkins.dev.yugabyte.com/job/users/job/yb-voyager-testing/job/yb-voyager-testing-pipeline/3793/

priyanshi-yb
priyanshi-yb approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@priyanshi-yb priyanshi-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanyamsinghal sanyamsinghal merged commit b00acf5 into main Oct 25, 2024
16 checks passed
@sanyamsinghal sanyamsinghal deleted the sanyam/fix-pgss-sql branch October 25, 2024 11:56
sanyamsinghal added a commit that referenced this pull request Oct 25, 2024
@sanyamsinghal
[#1796]Bug Fix: assess-migration failing on PG12 and below for db_que…
d2da0ed 
…ries psql script (#1801)

* removing extra columns from db-queries-summary script
* Fixed checks for REPORT_UNSUPPORTED_QUERY_CONSTRUCTS env var in pg gather metadata script
sanyamsinghal added a commit that referenced this pull request Oct 25, 2024
@sanyamsinghal
[#1796]Bug Fix: assess-migration failing on PG12 and below for db_que…
684f559 
…ries psql script (#1801) (#1804)

* removing extra columns from db-queries-summary script
* Fixed checks for REPORT_UNSUPPORTED_QUERY_CONSTRUCTS env var in pg gather metadata script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyanshi-yb priyanshi-yb priyanshi-yb approved these changes

@hbhanawat hbhanawat Awaiting requested review from hbhanawat

@shubham-yb shubham-yb Awaiting requested review from shubham-yb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanyamsinghal @priyanshi-yb