[BACKPORT 2.12][#13689] YSQL: Improve wording on how to vote on Githu…

…b issue Summary: There appears to be no way to click on '+' on the description, but in the reactions 👍 appears to be commonly used. Additionally use https://github.com/yugabyte/ instead of https://github.com/YugaByte/ in the links to those issues. Previously: HINT: See #1337. Click '+' on the description to raise its priority Now: HINT: See #1337. React with thumbs up to raise its priority Original commit: 4d83d04 / D18967 Test Plan: Unit tests Reviewers: mihnea, dmitry, jason Reviewed By: jason Subscribers: yql Differential Revision: https://phabricator.dev.yugabyte.com/D19120
yugabyte · Aug 24, 2022 · 0343d17 · 0343d17
1 parent 200731c
commit 0343d17
Show file tree

Hide file tree

Showing 40 changed files with 203 additions and 203 deletions.
diff --git a/src/postgres/contrib/cube/expected/yb_pg_cube.out b/src/postgres/contrib/cube/expected/yb_pg_cube.out
@@ -1508,7 +1508,7 @@ CREATE TABLE test_cube (c cube);
 \copy test_cube from 'data/test_cube.data'
 CREATE INDEX test_cube_ix ON test_cube USING gist (c);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 INSERT INTO test_cube VALUES ('(1,1)'), ('(100000)'), ('(0, 100000)'); -- Some corner cases
 RESET enable_seqscan;
 SET enable_indexscan = OFF;

diff --git a/src/postgres/contrib/hstore/expected/yb_pg_hstore.out b/src/postgres/contrib/hstore/expected/yb_pg_hstore.out
@@ -1305,7 +1305,7 @@ select count(*) from testhstore where h ?& ARRAY['public','disabled'];
 
 create index hidx on testhstore using gist(h);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 create index hidx on testhstore using gin (h);
 set enable_seqscan=off;
 select count(*) from testhstore where h @> 'wait=>NULL';

diff --git a/src/postgres/contrib/intarray/expected/yb_pg__int.out b/src/postgres/contrib/intarray/expected/yb_pg__int.out
@@ -448,9 +448,9 @@ SELECT count(*) from test__int WHERE a @@ '(20&23)|(50&68)';
 
 CREATE INDEX text_idx on test__int using gist ( a gist__int_ops );
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 CREATE INDEX text_idx on test__int using gist ( a gist__intbig_ops );
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 CREATE INDEX text_idx on test__int using gin ( a gin__int_ops );
 ERROR:  operator class "gin__int_ops" does not exist for access method "ybgin"
diff --git a/src/postgres/contrib/pg_trgm/expected/yb_pg_pg_strict_word_trgm.out b/src/postgres/contrib/pg_trgm/expected/yb_pg_pg_strict_word_trgm.out
@@ -77,7 +77,7 @@ select t <->>> 'Alaikallupoddakulam', t from test_trgm2 order by t <->>> 'Alaika
 
 create index trgm_idx2 on test_trgm2 using gist (t gist_trgm_ops);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 create index trgm_idx2 on test_trgm2 using gin (t gin_trgm_ops);
 set enable_seqscan=off;
 select t,strict_word_similarity('Baykal',t) as sml from test_trgm2 where 'Baykal' <<% t order by sml desc, t;

diff --git a/src/postgres/contrib/pg_trgm/expected/yb_pg_pg_trgm.out b/src/postgres/contrib/pg_trgm/expected/yb_pg_pg_trgm.out
@@ -1210,7 +1210,7 @@ select count(*) from test_trgm where t ~ '[qwerty]{2}-?[qwerty]{2}';
 
 create index trgm_idx on test_trgm using gist (t gist_trgm_ops);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 create index trgm_idx on test_trgm using gin (t gin_trgm_ops);
 set enable_seqscan=off;
 select t,similarity(t,'qwertyu0988') as sml from test_trgm where t % 'qwertyu0988' order by sml desc, t;
@@ -1391,7 +1391,7 @@ DETAIL:  ybgin index method cannot use more than one required scan entry: got 10
 drop index test2_idx_gin;
 create index test2_idx_gist on test2 using gist (t gist_trgm_ops);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 -- Check similarity threshold (bug #14202)
 CREATE TEMP TABLE restaurants (city text);
 INSERT INTO restaurants SELECT 'Warsaw' FROM generate_series(1, 10000);

diff --git a/src/postgres/contrib/pg_trgm/expected/yb_pg_pg_word_trgm.out b/src/postgres/contrib/pg_trgm/expected/yb_pg_pg_word_trgm.out
@@ -82,7 +82,7 @@ select t <->> 'Kabankala', t from test_trgm2 order by t <->> 'Kabankala' limit 7
 
 create index trgm_idx2 on test_trgm2 using gist (t gist_trgm_ops);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 create index trgm_idx2 on test_trgm2 using gin (t gin_trgm_ops);
 set enable_seqscan=off;
 select t,word_similarity('Baykal',t) as sml from test_trgm2 where 'Baykal' <% t order by sml desc, t;

diff --git a/src/postgres/src/backend/commands/indexcmds.c b/src/postgres/src/backend/commands/indexcmds.c
@@ -818,8 +818,8 @@ DefineIndex(Oid relationId,
 		ereport(ERROR,
 				(errmsg("index method \"%s\" not supported yet",
 						accessMethodName),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/1337. "
-						 "Click '+' on the description to raise its priority")));
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/1337. "
+						 "React with thumbs up to raise its priority")));
 	if (!IsYBRelation(rel) && (accessMethodId == LSM_AM_OID ||
 							   accessMethodId == YBGIN_AM_OID))
 		ereport(ERROR,

diff --git a/src/postgres/src/backend/parser/gram.y b/src/postgres/src/backend/parser/gram.y
@@ -17353,8 +17353,8 @@ raise_feature_not_supported_signal(int pos, core_yyscan_t yyscanner, const char
 		ereport(signal_level,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 				 errmsg("%s", msg),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/%d. "
-						 "Click '+' on the description to raise its priority", issue),
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/%d. "
+						 "React with thumbs up to raise its priority", issue),
 				 parser_errposition(pos)));
 
 	}

diff --git a/src/postgres/src/backend/parser/parse_utilcmd.c b/src/postgres/src/backend/parser/parse_utilcmd.c
@@ -1039,8 +1039,8 @@ YBCheckDeferrableConstraint(CreateStmtContext *cxt, Constraint *constraint)
 	ereport(ERROR,
 			 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 			 errmsg("%s", message),
-			 errhint("See https://github.com/YugaByte/yugabyte-db/issues/1129. "
-			         "Click '+' on the description to raise its priority"),
+			 errhint("See https://github.com/yugabyte/yugabyte-db/issues/1129. "
+			         "React with thumbs up to raise its priority"),
 			 parser_errposition(cxt->pstate, constraint->location)));
 }
 

diff --git a/src/postgres/src/backend/utils/adt/ruleutils.c b/src/postgres/src/backend/utils/adt/ruleutils.c
@@ -1539,7 +1539,7 @@ pg_get_indexdef_worker(Oid indexrelid, int colno,
 									   generate_relation_name(indrelid, NIL),
 									   yb_table_properties.num_tablets),
 							 errhint("See https://github.com/yugabyte/yugabyte-db/issues/4873."
-									 " Click '+' on the description to raise its priority.")));
+									 " React with thumbs up to raise its priority.")));
 				}
 			}
 

diff --git a/src/postgres/src/backend/utils/misc/pg_yb_utils.c b/src/postgres/src/backend/utils/misc/pg_yb_utils.c
@@ -876,8 +876,8 @@ YBRaiseNotSupportedSignal(const char *msg, int issue_no, int signal_level)
 		ereport(signal_level,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 				 errmsg("%s", msg),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/%d. "
-						 "Click '+' on the description to raise its priority", issue_no)));
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/%d. "
+						 "React with thumbs up to raise its priority", issue_no)));
 	}
 	else
 	{

diff --git a/src/postgres/src/pl/plpgsql/src/pl_gram.y b/src/postgres/src/pl/plpgsql/src/pl_gram.y
@@ -4100,8 +4100,8 @@ ybc_not_support(int pos, const char *feature, int issue) {
 		ereport(signal_level,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 				 errmsg("%s not supported yet", feature),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/%d. "
-						 "Click '+' on the description to raise its priority", issue),
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/%d. "
+						 "React with thumbs up to raise its priority", issue),
 				 parser_errposition(pos)));
 	}
 	else

diff --git a/src/postgres/src/test/regress/expected/yb_disabled.out b/src/postgres/src/test/regress/expected/yb_disabled.out
@@ -8,15 +8,15 @@ NOTIFY channel;
 WARNING:  NOTIFY not supported yet and will be ignored
 LINE 1: NOTIFY channel;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 NOTIFY channel, 'message';
 WARNING:  NOTIFY not supported yet and will be ignored
 LINE 1: NOTIFY channel, 'message';
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 SELECT pg_notify('channel', 'text');
 WARNING:  NOTIFY not supported yet and will be ignored
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
  pg_notify
 -----------
 
@@ -26,14 +26,14 @@ LISTEN channel;
 WARNING:  LISTEN not supported yet and will be ignored
 LINE 1: LISTEN channel;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 UNLISTEN channel;
 WARNING:  UNLISTEN not supported yet and will be ignored
 LINE 1: UNLISTEN channel;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 UNLISTEN *;
 WARNING:  UNLISTEN not supported yet and will be ignored
 LINE 1: UNLISTEN *;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
diff --git a/src/postgres/src/test/regress/expected/yb_pg_aggregates.out b/src/postgres/src/test/regress/expected/yb_pg_aggregates.out
@@ -815,7 +815,7 @@ create table minmaxtest1() inherits (minmaxtest);
 ERROR:  INHERITS not supported yet
 LINE 1: create table minmaxtest1() inherits (minmaxtest);
                                    ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1129. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1129. React with thumbs up to raise its priority
 -- create table minmaxtest2() inherits (minmaxtest);
 -- create table minmaxtest3() inherits (minmaxtest);
 create index minmaxtesti on minmaxtest(f1);

diff --git a/src/postgres/src/test/regress/expected/yb_pg_alter_generic.out b/src/postgres/src/test/regress/expected/yb_pg_alter_generic.out
@@ -39,14 +39,14 @@ ALTER AGGREGATE alt_func1(int) RENAME TO alt_func3;  -- failed (not aggregate)
 ERROR:  ALTER AGGREGATE not supported yet
 LINE 1: ALTER AGGREGATE alt_func1(int) RENAME TO alt_func3;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_func1(int) OWNER TO regress_alter_generic_user3;  -- failed (not aggregate)
 ERROR:  function alt_func1(integer) is not an aggregate
 ALTER AGGREGATE alt_func1(int) SET SCHEMA alt_nsp2;  -- failed (not aggregate)
 ERROR:  ALTER AGGREGATE SET SCHEMA not supported yet
 LINE 1: ALTER AGGREGATE alt_func1(int) SET SCHEMA alt_nsp2;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER FUNCTION alt_func1(int) RENAME TO alt_func2;  -- failed (name conflict)
 ERROR:  function alt_func2(integer) already exists in schema "alt_nsp1"
 ALTER FUNCTION alt_func1(int) RENAME TO alt_func3;  -- OK
@@ -59,20 +59,20 @@ ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg2;   -- failed (name conflict)
 ERROR:  ALTER AGGREGATE not supported yet
 LINE 1: ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg2;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg3;   -- OK
 ERROR:  ALTER AGGREGATE not supported yet
 LINE 1: ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg3;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_agg2(int) OWNER TO regress_alter_generic_user2;  -- failed (no role membership)
 ERROR:  must be member of role "regress_alter_generic_user2"
 ALTER AGGREGATE alt_agg2(int) OWNER TO regress_alter_generic_user3;  -- OK
 ALTER AGGREGATE alt_agg2(int) SET SCHEMA alt_nsp2;  -- OK
 ERROR:  ALTER AGGREGATE SET SCHEMA not supported yet
 LINE 1: ALTER AGGREGATE alt_agg2(int) SET SCHEMA alt_nsp2;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 SET SESSION AUTHORIZATION regress_alter_generic_user2;
 CREATE FUNCTION alt_func1(int) RETURNS int LANGUAGE sql
   AS 'SELECT $1 + 2';
@@ -101,25 +101,25 @@ ALTER AGGREGATE alt_agg3(int) RENAME TO alt_agg4;   -- failed (not owner)
 ERROR:  ALTER AGGREGATE not supported yet
 LINE 1: ALTER AGGREGATE alt_agg3(int) RENAME TO alt_agg4;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg4;   -- OK
 ERROR:  ALTER AGGREGATE not supported yet
 LINE 1: ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg4;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_agg3(int) OWNER TO regress_alter_generic_user2;  -- failed (not owner)
 ERROR:  aggregate alt_agg3(integer) does not exist
 ALTER AGGREGATE alt_agg2(int) OWNER TO regress_alter_generic_user3;  -- failed (no role membership)
 ALTER AGGREGATE alt_agg3(int) SET SCHEMA alt_nsp2;  -- failed (not owner)
 ERROR:  ALTER AGGREGATE SET SCHEMA not supported yet
 LINE 1: ALTER AGGREGATE alt_agg3(int) SET SCHEMA alt_nsp2;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_agg2(int) SET SCHEMA alt_nsp2;  -- failed (name conflict)
 ERROR:  ALTER AGGREGATE SET SCHEMA not supported yet
 LINE 1: ALTER AGGREGATE alt_agg2(int) SET SCHEMA alt_nsp2;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 RESET SESSION AUTHORIZATION;
 SELECT n.nspname, proname, prorettype::regtype, prokind, a.rolname
   FROM pg_proc p, pg_namespace n, pg_authid a