Skip to content

Commit

Permalink
[#23215] docdb: disable packed for colocated tables by default
Browse files Browse the repository at this point in the history
Summary:
Packed + colocated + restore can cause corruption of tablet schema packings: #23047
We are disabling the feature for now, will re-enable it when #23047 is fixed

`ysql_enable_packed_row_for_colocated_table` is on by default only in master, so it's sufficient to only land this diff to master.
Jira: DB-12158

Test Plan: Jenkins

Reviewers: rthallam

Reviewed By: rthallam

Subscribers: ybase, yql

Differential Revision: https://phorge.dev.yugabyte.com/D36591
  • Loading branch information
Huqicheng committed Jul 16, 2024
1 parent 08ca9dd commit 13c0ced
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ public void tearDown() throws Exception {
protected Map<String, String> getTServerFlags() {
Map<String, String> flagMap = super.getTServerFlags();
flagMap.put("ysql_analyze_dump_metrics", "true");
flagMap.put("ysql_enable_packed_row_for_colocated_table", "true");
return flagMap;
}

Expand Down
2 changes: 1 addition & 1 deletion src/yb/docdb/pgsql_operation.cc
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ DEFINE_RUNTIME_AUTO_bool(ysql_enable_packed_row, kNewInstallsOnly, false, true,
#endif
"Whether packed row is enabled for YSQL.");

DEFINE_UNKNOWN_bool(ysql_enable_packed_row_for_colocated_table, true,
DEFINE_RUNTIME_bool(ysql_enable_packed_row_for_colocated_table, false,
"Whether to enable packed row for colocated tables.");

DEFINE_UNKNOWN_uint64(
Expand Down
3 changes: 3 additions & 0 deletions src/yb/integration-tests/cdcsdk_test_base.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ DECLARE_bool(ysql_yb_enable_ddl_atomicity_infra);
DECLARE_bool(ysql_enable_pack_full_row_update);
DECLARE_bool(ysql_yb_enable_replica_identity);
DECLARE_bool(yb_enable_cdc_consistent_snapshot_streams);
DECLARE_bool(ysql_enable_packed_row_for_colocated_table);

namespace yb {
using client::YBClient;
Expand Down Expand Up @@ -137,6 +138,8 @@ class CDCSDKTestBase : public YBTest {
// TODO(#23000) Rationalize the tests to run with consistent / non-consistent snapshot streams.
ANNOTATE_UNPROTECTED_WRITE(FLAGS_yb_enable_cdc_consistent_snapshot_streams) = false;

ANNOTATE_UNPROTECTED_WRITE(FLAGS_ysql_enable_packed_row_for_colocated_table) = true;

google::SetVLOGLevel("cdc*", 4);
google::SetVLOGLevel("tablet*", 1);
}
Expand Down

0 comments on commit 13c0ced

Please sign in to comment.