[BACKPORT 2.6][#13689] YSQL: Improve wording on how to vote on Github…

… issue

Summary:
There appears to be no way to click on '+' on the description, but in the reactions 👍 appears to be commonly used. Additionally use https://github.com/yugabyte/ instead of https://github.com/YugaByte/ in the links to those issues.

Previously: HINT:  See #1337. Click '+' on the description to raise its priority

Now: HINT:  See #1337. React with thumbs up to raise its priority

Original commit: 4d83d04 / D18967

Test Plan: Unit tests

Reviewers: mihnea, dmitry, jason

Reviewed By: jason

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D19123

src/postgres/src/backend/commands/indexcmds.c

@@ -733,8 +733,8 @@ DefineIndex(Oid relationId,
 		ereport(ERROR,
 				(errmsg("index method \"%s\" not supported yet",
 						accessMethodName),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/1337. "
-						 "Click '+' on the description to raise its priority")));
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/1337. "
+						 "React with thumbs up to raise its priority")));
 	if (!IsYBRelation(rel) && accessMethodId == LSM_AM_OID)
 		ereport(ERROR,
 				(errmsg("access method \"%s\" only supported for indexes"

src/postgres/src/backend/executor/nodeModifyTable.c

@@ -1141,8 +1141,8 @@ ExecUpdate(ModifyTableState *mtstate,
 					(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 					 errmsg("This operation would cause a row to change the partition, "
 							"this is not yet supported"),
-					 errhint("See https://github.com/YugaByte/yugabyte-db/issues/%d. "
-							 "Click '+' on the description to raise its priority", 5310)));
+					 errhint("See https://github.com/yugabyte/yugabyte-db/issues/%d. "
+							 "React with thumbs up to raise its priority", 5310)));
 
 		RangeTblEntry *rte = rt_fetch(resultRelInfo->ri_RangeTableIndex,
 									  estate->es_range_table);

src/postgres/src/backend/parser/gram.y

@@ -17381,8 +17381,8 @@ raise_feature_not_supported_signal(int pos, core_yyscan_t yyscanner, const char
 		ereport(signal_level,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 				 errmsg("%s", msg),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/%d. "
-						 "Click '+' on the description to raise its priority", issue),
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/%d. "
+						 "React with thumbs up to raise its priority", issue),
 				 parser_errposition(pos)));
 
 	}

src/postgres/src/backend/parser/parse_utilcmd.c

@@ -952,8 +952,8 @@ YBCheckDeferrableConstraint(CreateStmtContext *cxt, Constraint *constraint)
 	ereport(ERROR,
 			 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 			 errmsg("%s", message),
-			 errhint("See https://github.com/YugaByte/yugabyte-db/issues/1129. "
-			         "Click '+' on the description to raise its priority"),
+			 errhint("See https://github.com/yugabyte/yugabyte-db/issues/1129. "
+			         "React with thumbs up to raise its priority"),
 			 parser_errposition(cxt->pstate, constraint->location)));
 }
 

src/postgres/src/backend/utils/misc/pg_yb_utils.c

@@ -743,8 +743,8 @@ YBRaiseNotSupportedSignal(const char *msg, int issue_no, int signal_level)
 		ereport(signal_level,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 				 errmsg("%s", msg),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/%d. "
-						 "Click '+' on the description to raise its priority", issue_no)));
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/%d. "
+						 "React with thumbs up to raise its priority", issue_no)));
 	}
 	else
 	{

src/postgres/src/pl/plpgsql/src/pl_gram.y

@@ -4097,8 +4097,8 @@ ybc_not_support(int pos, const char *feature, int issue) {
 		ereport(signal_level,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 				 errmsg("%s not supported yet", feature),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/%d. "
-						 "Click '+' on the description to raise its priority", issue),
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/%d. "
+						 "React with thumbs up to raise its priority", issue),
 				 parser_errposition(pos)));
 	}
 	else

src/postgres/src/test/regress/expected/yb_disabled.out

@@ -8,15 +8,15 @@ NOTIFY channel;
 WARNING:  NOTIFY not supported yet and will be ignored
 LINE 1: NOTIFY channel;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 NOTIFY channel, 'message';
 WARNING:  NOTIFY not supported yet and will be ignored
 LINE 1: NOTIFY channel, 'message';
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 SELECT pg_notify('channel', 'text');
 WARNING:  NOTIFY not supported yet and will be ignored
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
  pg_notify
 -----------
 
@@ -26,14 +26,14 @@ LISTEN channel;
 WARNING:  LISTEN not supported yet and will be ignored
 LINE 1: LISTEN channel;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 UNLISTEN channel;
 WARNING:  UNLISTEN not supported yet and will be ignored
 LINE 1: UNLISTEN channel;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 UNLISTEN *;
 WARNING:  UNLISTEN not supported yet and will be ignored
 LINE 1: UNLISTEN *;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority

src/postgres/src/test/regress/expected/yb_index_including.out

@@ -291,22 +291,22 @@ DROP TABLE tbl;
 CREATE TABLE tbl (c1 int,c2 int, c3 int, c4 int);
 CREATE INDEX on tbl USING brin(c1, c2) INCLUDE (c3, c4);
 ERROR:  index method "brin" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 CREATE INDEX on tbl USING gist(c3) INCLUDE (c4);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 CREATE INDEX on tbl USING spgist(c3) INCLUDE (c4);
 ERROR:  index method "spgist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 CREATE INDEX on tbl USING gin(c1, c2) INCLUDE (c3, c4);
 ERROR:  index method "gin" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 CREATE INDEX on tbl USING hash(c1, c2) INCLUDE (c3, c4);
 NOTICE:  index method "hash" was replaced with "lsm" in YugabyteDB
 CREATE INDEX on tbl USING rtree(c1, c2) INCLUDE (c3, c4);
 NOTICE:  substituting access method "gist" for obsolete method "rtree"
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 CREATE INDEX on tbl USING btree(c1, c2) INCLUDE (c3, c4);
 NOTICE:  index method "btree" was replaced with "lsm" in YugabyteDB
 CREATE INDEX on tbl USING lsm(c1, c2) INCLUDE (c3, c4);

src/postgres/src/test/regress/expected/yb_insert_conflict.out

@@ -566,7 +566,7 @@ alter table testoids set with oids;
 ERROR:  ALTER TABLE SET WITH OIDS not supported yet
 LINE 1: alter table testoids set with oids;
                              ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 -- update existing row, that didn't have an oid
 insert into testoids values(1, '3') on conflict (key) do update set data = excluded.data RETURNING *;
  key | data

src/postgres/src/test/regress/expected/yb_pg_aggregates.out

@@ -817,7 +817,7 @@ create table minmaxtest1() inherits (minmaxtest);
 ERROR:  INHERITS not supported yet
 LINE 1: create table minmaxtest1() inherits (minmaxtest);
                                    ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1129. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1129. React with thumbs up to raise its priority
 -- create table minmaxtest2() inherits (minmaxtest);
 -- create table minmaxtest3() inherits (minmaxtest);
 create index minmaxtesti on minmaxtest(f1);

src/postgres/src/test/regress/expected/yb_pg_alter_generic.out

@@ -41,14 +41,14 @@ ALTER AGGREGATE alt_func1(int) RENAME TO alt_func3;  -- failed (not aggregate)
 ERROR:  ALTER AGGREGATE not supported yet
 LINE 1: ALTER AGGREGATE alt_func1(int) RENAME TO alt_func3;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_func1(int) OWNER TO regress_alter_generic_user3;  -- failed (not aggregate)
 ERROR:  function alt_func1(integer) is not an aggregate
 ALTER AGGREGATE alt_func1(int) SET SCHEMA alt_nsp2;  -- failed (not aggregate)
 ERROR:  ALTER AGGREGATE SET SCHEMA not supported yet
 LINE 1: ALTER AGGREGATE alt_func1(int) SET SCHEMA alt_nsp2;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER FUNCTION alt_func1(int) RENAME TO alt_func2;  -- failed (name conflict)
 ERROR:  function alt_func2(integer) already exists in schema "alt_nsp1"
 ALTER FUNCTION alt_func1(int) RENAME TO alt_func3;  -- OK
@@ -61,20 +61,20 @@ ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg2;   -- failed (name conflict)
 ERROR:  ALTER AGGREGATE not supported yet
 LINE 1: ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg2;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg3;   -- OK
 ERROR:  ALTER AGGREGATE not supported yet
 LINE 1: ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg3;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_agg2(int) OWNER TO regress_alter_generic_user2;  -- failed (no role membership)
 ERROR:  must be member of role "regress_alter_generic_user2"
 ALTER AGGREGATE alt_agg2(int) OWNER TO regress_alter_generic_user3;  -- OK
 ALTER AGGREGATE alt_agg2(int) SET SCHEMA alt_nsp2;  -- OK
 ERROR:  ALTER AGGREGATE SET SCHEMA not supported yet
 LINE 1: ALTER AGGREGATE alt_agg2(int) SET SCHEMA alt_nsp2;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 SET SESSION AUTHORIZATION regress_alter_generic_user2;
 CREATE FUNCTION alt_func1(int) RETURNS int LANGUAGE sql
   AS 'SELECT $1 + 2';
@@ -103,25 +103,25 @@ ALTER AGGREGATE alt_agg3(int) RENAME TO alt_agg4;   -- failed (not owner)
 ERROR:  ALTER AGGREGATE not supported yet
 LINE 1: ALTER AGGREGATE alt_agg3(int) RENAME TO alt_agg4;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg4;   -- OK
 ERROR:  ALTER AGGREGATE not supported yet
 LINE 1: ALTER AGGREGATE alt_agg1(int) RENAME TO alt_agg4;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_agg3(int) OWNER TO regress_alter_generic_user2;  -- failed (not owner)
 ERROR:  aggregate alt_agg3(integer) does not exist
 ALTER AGGREGATE alt_agg2(int) OWNER TO regress_alter_generic_user3;  -- failed (no role membership)
 ALTER AGGREGATE alt_agg3(int) SET SCHEMA alt_nsp2;  -- failed (not owner)
 ERROR:  ALTER AGGREGATE SET SCHEMA not supported yet
 LINE 1: ALTER AGGREGATE alt_agg3(int) SET SCHEMA alt_nsp2;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 ALTER AGGREGATE alt_agg2(int) SET SCHEMA alt_nsp2;  -- failed (name conflict)
 ERROR:  ALTER AGGREGATE SET SCHEMA not supported yet
 LINE 1: ALTER AGGREGATE alt_agg2(int) SET SCHEMA alt_nsp2;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/2717. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/2717. React with thumbs up to raise its priority
 RESET SESSION AUTHORIZATION;
 SELECT n.nspname, proname, prorettype::regtype, prokind, a.rolname
   FROM pg_proc p, pg_namespace n, pg_authid a

src/postgres/src/test/regress/expected/yb_pg_create_table.out

@@ -78,21 +78,21 @@ CREATE TABLE emp (
 ERROR:  INHERITS not supported yet
 LINE 4: ) INHERITS (person);
           ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1129. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1129. React with thumbs up to raise its priority
 CREATE TABLE student (
 	gpa 		float8
 ) INHERITS (person);
 ERROR:  INHERITS not supported yet
 LINE 3: ) INHERITS (person);
           ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1129. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1129. React with thumbs up to raise its priority
 CREATE TABLE stud_emp (
 	percent 	int4
 ) INHERITS (emp, student);
 ERROR:  INHERITS not supported yet
 LINE 3: ) INHERITS (emp, student);
           ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1129. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1129. React with thumbs up to raise its priority
 CREATE TABLE city (
 	name		name,
 	location 	box,
@@ -116,14 +116,14 @@ CREATE TABLE ihighway () INHERITS (road);
 ERROR:  INHERITS not supported yet
 LINE 1: CREATE TABLE ihighway () INHERITS (road);
                                  ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1129. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1129. React with thumbs up to raise its priority
 CREATE TABLE shighway (
 	surface		text
 ) INHERITS (road);
 ERROR:  INHERITS not supported yet
 LINE 3: ) INHERITS (road);
           ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1129. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1129. React with thumbs up to raise its priority
 CREATE TABLE real_city (
 	pop			int4,
 	cname		text,

src/postgres/src/test/regress/expected/yb_pg_enum.out

@@ -596,7 +596,7 @@ ALTER TYPE bogus RENAME TO bogon;
 ERROR:  ALTER TYPE not supported yet
 LINE 1: ALTER TYPE bogus RENAME TO bogon;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1893. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1893. React with thumbs up to raise its priority
 ALTER TYPE bogon ADD VALUE 'bad';
 ERROR:  current transaction is aborted, commands ignored until end of transaction block
 ROLLBACK;

src/postgres/src/test/regress/expected/yb_pg_event_trigger.out

@@ -267,19 +267,19 @@ DROP SCHEMA schema_one, schema_two CASCADE;
 ERROR:  DROP multiple objects not supported yet
 LINE 1: DROP SCHEMA schema_one, schema_two CASCADE;
                     ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/880. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/880. React with thumbs up to raise its priority
 DELETE FROM undroppable_objs WHERE object_identity = 'audit_tbls.schema_two_table_three';
 DROP SCHEMA schema_one, schema_two CASCADE;
 ERROR:  DROP multiple objects not supported yet
 LINE 1: DROP SCHEMA schema_one, schema_two CASCADE;
                     ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/880. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/880. React with thumbs up to raise its priority
 DELETE FROM undroppable_objs WHERE object_identity = 'schema_one.table_three';
 DROP SCHEMA schema_one, schema_two CASCADE;
 ERROR:  DROP multiple objects not supported yet
 LINE 1: DROP SCHEMA schema_one, schema_two CASCADE;
                     ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/880. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/880. React with thumbs up to raise its priority
 -- ignoring tests related to cascade
 -- SELECT * FROM dropped_objects WHERE schema IS NULL OR schema <> 'pg_toast';
 DROP OWNED BY regress_evt_user;
@@ -419,14 +419,14 @@ alter type rewritetype alter attribute a type text cascade;
 ERROR:  ALTER TYPE ALTER ATTRIBUTE not supported yet
 LINE 1: alter type rewritetype alter attribute a type text cascade;
                                ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1893. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1893. React with thumbs up to raise its priority
 -- but this doesn't work
 create table rewritemetoo3 (a rewritetype);
 alter type rewritetype alter attribute a type varchar cascade;
 ERROR:  ALTER TYPE ALTER ATTRIBUTE not supported yet
 LINE 1: alter type rewritetype alter attribute a type varchar cascad...
                                ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1893. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1893. React with thumbs up to raise its priority
 drop table rewriteme;
 drop event trigger no_rewrite_allowed;
 drop function test_evtrig_no_rewrite();