-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[#21789] docdb: Add tablet splitting support for clone
Summary: This diff adds tablet splitting support for clone. Specifically: - `CatalogManager::GetBackupEntriesAsOfTime` now returns the set of active tablets (tablets that have not been split) instead of RUNNING and not-hidden tablets. Previously, we could return both the split parent and children until the split parent is deleted. This was causing a `ImportSnapshot` to fail because we were trying to create two tablets with the same partition start key (we do not have the split depth to disambiguate in `ImportSnapshot`). - This could fail to cover the space if just one tablet is registered. This gap will be fixed by D31428 (until then, we cannot clone to the time when only one tablet is registered) - In `CloneStateManager::ScheduleCloneOps`, changed the check before cloning from active rocksdb from "tablet is hidden" to "tablet is hidden or split". - This covers the case where a split happens at time t1, and we clone to before t1 using a snapshot taken after the parent is hidden (so the snapshot does not contain the split parent) Jira: DB-10680 Test Plan: ``` ./yb_build.sh release --cxx-test integration-tests_minicluster-snapshot-test --gtest_filter PgCloneTest.TabletSplitting ./yb_build.sh release --cxx-test integration-tests_minicluster-snapshot-test --gtest_filter PgCloneTest.TabletSplittingWithIndex ``` Reviewers: mhaddad Reviewed By: mhaddad Subscribers: ybase Differential Revision: https://phorge.dev.yugabyte.com/D36440
- Loading branch information
1 parent
835e30d
commit 3273e9b
Showing
5 changed files
with
134 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters