Skip to content

Commit

Permalink
#97: Fix for Fatal failure on scaling down kubernetes cluster
Browse files Browse the repository at this point in the history
Summary:
Fixed `ResolveInetAddresses` to use `VERIFY_RESULT` instead of `CHECK_RESULT`, so it
doesn't exit process with fatal failure in case of inet address resolution issues.

Test Plan: Jenkins. Create Kubernetes cluster, try to scale up and down.

Reviewers: karthik, sergei, kannan

Reviewed By: kannan

Subscribers: kannan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D4370
  • Loading branch information
ttyusupov committed Mar 15, 2018
1 parent a60c81f commit 40786a4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/yb/util/net/net_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ Result<std::unique_ptr<addrinfo, AddrinfoDeleter>> HostToInetAddrInfo(const std:

template <typename F>
CHECKED_STATUS ResolveInetAddresses(const std::string& host, F func) {
auto addrinfo_holder = CHECK_RESULT(HostToInetAddrInfo(host));
auto addrinfo_holder = VERIFY_RESULT(HostToInetAddrInfo(host));
struct addrinfo* addrinfo = addrinfo_holder.get();
for (; addrinfo != nullptr; addrinfo = addrinfo->ai_next) {
CHECK_EQ(addrinfo->ai_family, AF_INET);
Expand Down

0 comments on commit 40786a4

Please sign in to comment.