[BACKPORT 2.14][#13689] YSQL: Improve wording on how to vote on Githu…

…b issue

Summary:
There appears to be no way to click on '+' on the description, but in the reactions 👍 appears to be commonly used. Additionally use https://github.com/yugabyte/ instead of https://github.com/YugaByte/ in the links to those issues.

Previously: HINT:  See #1337. Click '+' on the description to raise its priority

Now: HINT:  See #1337. React with thumbs up to raise its priority

Original commit: 4d83d04 / D18967

Test Plan: Unit tests

Reviewers: mihnea, dmitry, jason

Reviewed By: jason

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D19118

src/postgres/contrib/cube/expected/yb_pg_cube.out

@@ -1508,7 +1508,7 @@ CREATE TABLE test_cube (c cube);
 \copy test_cube from 'data/test_cube.data'
 CREATE INDEX test_cube_ix ON test_cube USING gist (c);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 INSERT INTO test_cube VALUES ('(1,1)'), ('(100000)'), ('(0, 100000)'); -- Some corner cases
 RESET enable_seqscan;
 SET enable_indexscan = OFF;

src/postgres/contrib/file_fdw/output/yb_pg_file_fdw.source

@@ -110,7 +110,7 @@ ALTER FOREIGN TABLE text_csv OPTIONS (SET format 'csv');
 ERROR:  ALTER TABLE not supported yet
 LINE 1: ALTER FOREIGN TABLE text_csv OPTIONS (SET format 'csv');
                                      ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 DROP FOREIGN TABLE text_csv;
 CREATE FOREIGN TABLE text_csv (
     word1 text OPTIONS (force_not_null 'true'),
@@ -272,7 +272,7 @@ ALTER FOREIGN TABLE agg_csv INHERIT agg;
 ERROR:  ALTER TABLE INHERIT not supported yet
 LINE 1: ALTER FOREIGN TABLE agg_csv INHERIT agg;
                                     ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 --SELECT tableoid::regclass, * FROM agg;
 --SELECT tableoid::regclass, * FROM agg_csv;
 --SELECT tableoid::regclass, * FROM ONLY agg;
@@ -419,14 +419,14 @@ ALTER FOREIGN TABLE agg_text OPTIONS (SET format 'text');
 ERROR:  ALTER TABLE not supported yet
 LINE 1: ALTER FOREIGN TABLE agg_text OPTIONS (SET format 'text');
                                      ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 SET ROLE regress_file_fdw_user;
 -- YB note: Change expected output when ALTER TABLE from #1124 is supported
 ALTER FOREIGN TABLE agg_text OPTIONS (SET format 'text');
 ERROR:  ALTER TABLE not supported yet
 LINE 1: ALTER FOREIGN TABLE agg_text OPTIONS (SET format 'text');
                                      ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 SET ROLE regress_file_fdw_superuser;
 -- cleanup
 RESET ROLE;

src/postgres/contrib/hstore/expected/yb_pg_hstore.out

@@ -1305,7 +1305,7 @@ select count(*) from testhstore where h ?& ARRAY['public','disabled'];
 
 create index hidx on testhstore using gist(h);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 create index hidx on testhstore using gin (h);
 set enable_seqscan=off;
 select count(*) from testhstore where h @> 'wait=>NULL';

src/postgres/contrib/intarray/expected/yb_pg__int.out

@@ -448,9 +448,9 @@ SELECT count(*) from test__int WHERE a @@ '(20&23)|(50&68)';
 
 CREATE INDEX text_idx on test__int using gist ( a gist__int_ops );
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 CREATE INDEX text_idx on test__int using gist ( a gist__intbig_ops );
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 CREATE INDEX text_idx on test__int using gin ( a gin__int_ops );
 ERROR:  operator class "gin__int_ops" does not exist for access method "ybgin"

src/postgres/contrib/pg_trgm/expected/yb_pg_pg_strict_word_trgm.out

@@ -77,7 +77,7 @@ select t <->>> 'Alaikallupoddakulam', t from test_trgm2 order by t <->>> 'Alaika
 
 create index trgm_idx2 on test_trgm2 using gist (t gist_trgm_ops);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 create index trgm_idx2 on test_trgm2 using gin (t gin_trgm_ops);
 set enable_seqscan=off;
 select t,strict_word_similarity('Baykal',t) as sml from test_trgm2 where 'Baykal' <<% t order by sml desc, t;

src/postgres/contrib/pg_trgm/expected/yb_pg_pg_trgm.out

@@ -1210,7 +1210,7 @@ select count(*) from test_trgm where t ~ '[qwerty]{2}-?[qwerty]{2}';
 
 create index trgm_idx on test_trgm using gist (t gist_trgm_ops);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 create index trgm_idx on test_trgm using gin (t gin_trgm_ops);
 set enable_seqscan=off;
 select t,similarity(t,'qwertyu0988') as sml from test_trgm where t % 'qwertyu0988' order by sml desc, t;
@@ -1391,7 +1391,7 @@ DETAIL:  ybgin index method cannot use more than one required scan entry: got 10
 drop index test2_idx_gin;
 create index test2_idx_gist on test2 using gist (t gist_trgm_ops);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 -- Check similarity threshold (bug #14202)
 CREATE TEMP TABLE restaurants (city text);
 INSERT INTO restaurants SELECT 'Warsaw' FROM generate_series(1, 10000);

src/postgres/contrib/pg_trgm/expected/yb_pg_pg_word_trgm.out

@@ -82,7 +82,7 @@ select t <->> 'Kabankala', t from test_trgm2 order by t <->> 'Kabankala' limit 7
 
 create index trgm_idx2 on test_trgm2 using gist (t gist_trgm_ops);
 ERROR:  index method "gist" not supported yet
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1337. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1337. React with thumbs up to raise its priority
 create index trgm_idx2 on test_trgm2 using gin (t gin_trgm_ops);
 set enable_seqscan=off;
 select t,word_similarity('Baykal',t) as sml from test_trgm2 where 'Baykal' <% t order by sml desc, t;

src/postgres/contrib/postgres_fdw/expected/yb_pg_postgres_fdw.out

@@ -144,7 +144,7 @@ ALTER TABLE ft_pg_type SET WITH OIDS;
 ERROR:  ALTER TABLE SET WITH OIDS not supported yet
 LINE 1: ALTER TABLE ft_pg_type SET WITH OIDS;
                                ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 -- ===================================================================
 -- tests for validator
 -- ===================================================================
@@ -194,12 +194,12 @@ ALTER FOREIGN TABLE ft1 OPTIONS (schema_name 'S 1', table_name 'T 1');
 ERROR:  ALTER TABLE not supported yet
 LINE 1: ALTER FOREIGN TABLE ft1 OPTIONS (schema_name 'S 1', table_na...
                                 ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 ALTER FOREIGN TABLE ft2 OPTIONS (schema_name 'S 1', table_name 'T 1');
 ERROR:  ALTER TABLE not supported yet
 LINE 1: ALTER FOREIGN TABLE ft2 OPTIONS (schema_name 'S 1', table_na...
                                 ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 ALTER FOREIGN TABLE ft1 ALTER COLUMN c1 OPTIONS (column_name 'C 1');
 ERROR:  option "column_name" provided more than once
 ALTER FOREIGN TABLE ft2 ALTER COLUMN c1 OPTIONS (column_name 'C 1');
@@ -262,7 +262,7 @@ ALTER FOREIGN TABLE ft2 OPTIONS (use_remote_estimate 'true');
 ERROR:  ALTER TABLE not supported yet
 LINE 1: ALTER FOREIGN TABLE ft2 OPTIONS (use_remote_estimate 'true')...
                                 ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 -- ===================================================================
 -- simple queries
 -- ===================================================================
@@ -2263,7 +2263,7 @@ ALTER VIEW v5 OWNER TO regress_view_owner;
 ERROR:  ALTER VIEW not supported yet
 LINE 1: ALTER VIEW v5 OWNER TO regress_view_owner;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1131. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1131. React with thumbs up to raise its priority
 --EXPLAIN (VERBOSE, COSTS OFF)
 --SELECT t1.c1, t2.c2 FROM v4 t1 LEFT JOIN v5 t2 ON (t1.c1 = t2.c1) ORDER BY t1.c1, t2.c1 OFFSET 10 LIMIT 10;  -- can't be pushed down, different view owners
 --SELECT t1.c1, t2.c2 FROM v4 t1 LEFT JOIN v5 t2 ON (t1.c1 = t2.c1) ORDER BY t1.c1, t2.c1 OFFSET 10 LIMIT 10;
@@ -6771,7 +6771,7 @@ ALTER TABLE base_tbl SET (autovacuum_enabled = 'false');
 ERROR:  ALTER TABLE SET not supported yet
 LINE 1: ALTER TABLE base_tbl SET (autovacuum_enabled = 'false');
                              ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 CREATE FOREIGN TABLE foreign_tbl (a int, b int)
   SERVER loopback OPTIONS(table_name 'base_tbl');
 CREATE VIEW rw_view AS SELECT * FROM foreign_tbl
@@ -7353,7 +7353,7 @@ CREATE FOREIGN TABLE b (bb TEXT) INHERITS (a)
 ERROR:  INHERITS not supported yet
 LINE 1: CREATE FOREIGN TABLE b (bb TEXT) INHERITS (a)
                                          ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1129. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1129. React with thumbs up to raise its priority
 --INSERT INTO a(aa) VALUES('aaa');
 --INSERT INTO a(aa) VALUES('aaaa');
 --INSERT INTO a(aa) VALUES('aaaaa');
@@ -7783,7 +7783,7 @@ alter table loc2 set (autovacuum_enabled = 'false');
 ERROR:  ALTER TABLE SET not supported yet
 LINE 1: alter table loc2 set (autovacuum_enabled = 'false');
                          ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 create foreign table rem2 (f1 int, f2 text) server loopback options(table_name 'loc2');
 -- YB note: catalog snapshot invalidated, remove pg_sleeps when issue #11554 is fixed
 select pg_sleep(1);
@@ -8316,7 +8316,7 @@ ALTER FOREIGN TABLE table30000 OPTIONS ( SET fetch_size '60000');
 ERROR:  ALTER TABLE not supported yet
 LINE 1: ALTER FOREIGN TABLE table30000 OPTIONS ( SET fetch_size '600...
                                        ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1124. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1124. React with thumbs up to raise its priority
 --SELECT COUNT(*)
 --FROM pg_foreign_table
 --WHERE ftrelid = 'table30000'::regclass

src/postgres/src/backend/commands/indexcmds.c

@@ -854,8 +854,8 @@ DefineIndex(Oid relationId,
 		ereport(ERROR,
 				(errmsg("index method \"%s\" not supported yet",
 						accessMethodName),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/1337. "
-						 "Click '+' on the description to raise its priority")));
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/1337. "
+						 "React with thumbs up to raise its priority")));
 	if (!IsYBRelation(rel) && (accessMethodId == LSM_AM_OID ||
 							   accessMethodId == YBGIN_AM_OID))
 		ereport(ERROR,

src/postgres/src/backend/parser/gram.y

@@ -17358,8 +17358,8 @@ raise_feature_not_supported_signal(int pos, core_yyscan_t yyscanner, const char
 		ereport(signal_level,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 				 errmsg("%s", msg),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/%d. "
-						 "Click '+' on the description to raise its priority", issue),
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/%d. "
+						 "React with thumbs up to raise its priority", issue),
 				 parser_errposition(pos)));
 
 	}

src/postgres/src/backend/parser/parse_utilcmd.c

@@ -1039,8 +1039,8 @@ YBCheckDeferrableConstraint(CreateStmtContext *cxt, Constraint *constraint)
 	ereport(ERROR,
 			 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 			 errmsg("%s", message),
-			 errhint("See https://github.com/YugaByte/yugabyte-db/issues/1129. "
-			         "Click '+' on the description to raise its priority"),
+			 errhint("See https://github.com/yugabyte/yugabyte-db/issues/1129. "
+			         "React with thumbs up to raise its priority"),
 			 parser_errposition(cxt->pstate, constraint->location)));
 }
 

src/postgres/src/backend/utils/adt/ruleutils.c

@@ -1539,7 +1539,7 @@ pg_get_indexdef_worker(Oid indexrelid, int colno,
 									   generate_relation_name(indrelid, NIL),
 									   yb_table_properties.num_tablets),
 							 errhint("See https://github.com/yugabyte/yugabyte-db/issues/4873."
-									 " Click '+' on the description to raise its priority.")));
+									 " React with thumbs up to raise its priority.")));
 				}
 			}
 

src/postgres/src/backend/utils/misc/pg_yb_utils.c

@@ -910,8 +910,8 @@ YBRaiseNotSupportedSignal(const char *msg, int issue_no, int signal_level)
 		ereport(signal_level,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 				 errmsg("%s", msg),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/%d. "
-						 "Click '+' on the description to raise its priority", issue_no)));
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/%d. "
+						 "React with thumbs up to raise its priority", issue_no)));
 	}
 	else
 	{

src/postgres/src/pl/plpgsql/src/pl_gram.y

@@ -4100,8 +4100,8 @@ ybc_not_support(int pos, const char *feature, int issue) {
 		ereport(signal_level,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 				 errmsg("%s not supported yet", feature),
-				 errhint("See https://github.com/YugaByte/yugabyte-db/issues/%d. "
-						 "Click '+' on the description to raise its priority", issue),
+				 errhint("See https://github.com/yugabyte/yugabyte-db/issues/%d. "
+						 "React with thumbs up to raise its priority", issue),
 				 parser_errposition(pos)));
 	}
 	else

src/postgres/src/test/regress/expected/yb_disabled.out

@@ -8,15 +8,15 @@ NOTIFY channel;
 WARNING:  NOTIFY not supported yet and will be ignored
 LINE 1: NOTIFY channel;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 NOTIFY channel, 'message';
 WARNING:  NOTIFY not supported yet and will be ignored
 LINE 1: NOTIFY channel, 'message';
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 SELECT pg_notify('channel', 'text');
 WARNING:  NOTIFY not supported yet and will be ignored
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
  pg_notify
 -----------
 
@@ -26,14 +26,14 @@ LISTEN channel;
 WARNING:  LISTEN not supported yet and will be ignored
 LINE 1: LISTEN channel;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 UNLISTEN channel;
 WARNING:  UNLISTEN not supported yet and will be ignored
 LINE 1: UNLISTEN channel;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority
 UNLISTEN *;
 WARNING:  UNLISTEN not supported yet and will be ignored
 LINE 1: UNLISTEN *;
         ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1872. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1872. React with thumbs up to raise its priority

src/postgres/src/test/regress/expected/yb_pg_aggregates.out

@@ -822,7 +822,7 @@ create table minmaxtest1() inherits (minmaxtest);
 ERROR:  INHERITS not supported yet
 LINE 1: create table minmaxtest1() inherits (minmaxtest);
                                    ^
-HINT:  See https://github.com/YugaByte/yugabyte-db/issues/1129. Click '+' on the description to raise its priority
+HINT:  See https://github.com/yugabyte/yugabyte-db/issues/1129. React with thumbs up to raise its priority
 -- create table minmaxtest2() inherits (minmaxtest);
 -- create table minmaxtest3() inherits (minmaxtest);
 create index minmaxtesti on minmaxtest(f1);