-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PLAT-14471][PLAT-14576] Added configurable deadline, keepAlive and u…
…navailable retries to Ybc Java client Summary: [PLAT-14471] Contains YBC commit: yugabyte/ybc@62939b0 Added configurable deadline, keepAlive and unavailable retries to Ybc Java client. These settings are configurable via global runtime configs. ISSUE Saw hung connections without a proper RCA. The DB node had an established TCP connection but the client does not seem to receive response. The Ybc Java client thread hung forever. CHANGES Adding the following 3 changes to client code: - Upgraded the grpc-java version to 1.63.1 - Added deadline to in-progress RPCs. Added 20 minutes deadline to in-flight RPCs. If the RPC does not receive a response within 20 minutes, the client call will fail with DEADLINE_EXCEEDED. This will not be retried. - Added keepAlive and keepAliveTimeout. The keepAlive makes periodic calls to grpc server and waits for reply. This happens only when an RPC is in-flight. If the ping does not reply within keepAliveTimeout timeframe, the call will fail with UNAVAILABLE. The RPC will then be retried by the Ybc Java client. Current values are 6 minutes for keepAlive and 2 minutes for keepAliveTimeout. TEST Tested with making modifications such that the call does not return in 20 minutes. The exception raised was DEADLINE_EXCEEDED as expected. [PLAT-14576] Contains YBC commit: yugabyte/ybc@d423da2 Fix catalog version mechanism to use database being backed up ISSUE Earlier DB used to have a global catalog version so we used template1 DB to run the yb_catalog_version() sql command. But now we have catalog version per DB so we should use the DB to be backed up to fetch the catalog version. CHANGES The PR changes catalog_version sql to connect to database being backed up. Added grpc-inprocess 1.63.1 dependency. Test Plan: Manually verified Reviewers: kkg, nsingh Reviewed By: kkg Subscribers: yugaware Differential Revision: https://phorge.dev.yugabyte.com/D36087
- Loading branch information
1 parent
68cb1d2
commit db445ce
Showing
4 changed files
with
117 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters