Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add Tablegroups to the \h menu #10089

Closed
timothy-e opened this issue Sep 23, 2021 · 1 comment
Closed

[docs] add Tablegroups to the \h menu #10089

timothy-e opened this issue Sep 23, 2021 · 1 comment
Assignees
Labels
area/ysql Yugabyte SQL (YSQL)

Comments

@timothy-e
Copy link
Contributor

Add \h ALTER TABLEGROUP, \h CREATE TABLEGROUP, and \h DROP TABLEGROUP.

Should look like:

yugabyte=# \h ALTER TABLEGROUP
Command:     ALTER TABLEGROUP
Description: change the definition of a tablegroup
Syntax:
ALTER TABLEGROUP name RENAME TO new_name
ALTER TABLEGROUP name OWNER TO { new_owner | CURRENT_USER | SESSION_USER }

There is nothing else about a tablegroup that can be set right now, so nothing else to support altering.

yugabyte=# \h CREATE TABLEGROUP
Command:     CREATE TABLEGROUP
Description: define a new tablegroup
Syntax:
CREATE TABLEGROUP tablegroup_name

No other options are supported currently in the creation of tablegroups.

yugabyte=# \h DROP TABLEGROUP
Command:     DROP TABLEGROUP
Description: remove a tablegroup
Syntax:
DROP TABLEGROUP name

Other DROP statements support IF EXISTS (e.g. DROP TABLESPACE IF EXISTS tblspace) but tablegroups do not.

@timothy-e timothy-e added area/documentation Documentation needed area/ysql Yugabyte SQL (YSQL) labels Sep 23, 2021
@timothy-e timothy-e self-assigned this Sep 23, 2021
@aishwarya24 aishwarya24 added this to Backlog in Documentation via automation Oct 8, 2021
@polarweasel polarweasel removed the area/documentation Documentation needed label Oct 14, 2021
@polarweasel polarweasel removed this from Backlog in Documentation Oct 14, 2021
@polarweasel
Copy link
Contributor

@timothy-e this isn't actually a docs issue, since the \h output comes from the YSQL executable itself. Please ping @m-iancu to assign this one to the correct team member(s).

timothy-e added a commit that referenced this issue Oct 22, 2021
Summary:
Fixes T10089

We have some translation files at `/src/postgres/src/bin/psql/po/`. I didn't touch those because they haven't been touched since they were introduced in January 2019.

Test Plan: `ybd --java-test 'org.yb.pgsql.TestPgRegressTablegroup#testPgRegressTablegroup'`

Reviewers: dsrinivasan

Reviewed By: dsrinivasan

Differential Revision: https://phabricator.dev.yugabyte.com/D13154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL)
Projects
None yet
Development

No branches or pull requests

2 participants