-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xCluster] Slow SetupReplication requests when using too many tables #10611
Comments
It looks like the culprit here is Update: This is handle in batch, so we're fine here. We were creating new network connections per table within this code, which became expensive when connection costs are high. |
… tables Summary: Currently, setup_replication times out when using too many tables. The workaround is to batch into multiple entries with ~10 tables. When investigating, found that we were serially creating a YBClient object, per table, that required 5 sec to startup. Modified to use a cached object and added 2 basic unit tests to run the setup_replication command with 100 tables and verify a reasonable runtime. Test Plan: TwoDCTestParams/TwoDCTest.BootstrapAndSetupLargeTableCount/0 -n 10 TwoDCTestParams/TwoDCTest.SetupUniverseReplicationLargeTableCount/0 -n 10 Reviewers: jhe, rahuldesirazu Reviewed By: rahuldesirazu Subscribers: ybase, bogdan Differential Revision: https://phabricator.dev.yugabyte.com/D15256
…too many tables Summary: Currently, setup_replication times out when using too many tables. The workaround is to batch into multiple entries with ~10 tables. When investigating, found that we were serially creating a YBClient object, per table, that required 5 sec to startup. Modified to use a cached object and added 2 basic unit tests to run the setup_replication command with 100 tables and verify a reasonable runtime. Test Plan: TwoDCTestParams/TwoDCTest.BootstrapAndSetupLargeTableCount/0 -n 10 TwoDCTestParams/TwoDCTest.SetupUniverseReplicationLargeTableCount/0 -n 10 Reviewers: jhe, rahuldesirazu Reviewed By: rahuldesirazu Subscribers: ybase, bogdan Differential Revision: https://phabricator.dev.yugabyte.com/D15256
Description
Similar to #10065,
yb-admin setup_replication
also times out when using too many tables. We had a customer who used 100 tables as command input. The current workaround is to batch into multiple entries with ~10 tables. A performance issue with the command, not the feature.The text was updated successfully, but these errors were encountered: