Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform][Kubernetes] Zone configurations are overwritten when kubeconfig is not provided #10860

Closed
bhavin192 opened this issue Dec 13, 2021 · 0 comments · Fixed by #10928
Closed

[Platform][Kubernetes] Zone configurations are overwritten when kubeconfig is not provided #10860

bhavin192 opened this issue Dec 13, 2021 · 0 comments · Fixed by #10928
Labels
area/kubernetes Kubernetes support and deployments. area/platform Yugabyte Platform

Comments

@bhavin192
Copy link
Contributor

Description

The commit d29f73f#diff-fc957da0b60dcc2d3632c191ca98d5b5d765d560800f4a34b0e224fc3232d1acR262 added support for in-cluster credentials. It basically sets KUBECONFIG variable to a blank string.

It uses az.setConfig whose behavior has been changed in c0b9786#diff-440e6f700b5643beb4942f556420450439b718acf8faf493cd5c7311be538274R66

So, when we don't upload kubeconfig, it replaces all the AZ level configs such as Helm overrides with {"KUBECONFIG": ""}. It should be changed to use the new method az.updateConfig instead.
@bhavin192 bhavin192 added area/kubernetes Kubernetes support and deployments. area/platform Yugabyte Platform labels Dec 13, 2021
bhavin192 added a commit to bhavin192/yugabyte-db that referenced this issue Dec 22, 2021
@bhavin192
[Platform][Kubernetes] Use az.updateConfig for incluster credentials
8c8a553 
c0b9786 changed the behavior of
az.setConfig and added az.updateConfig. This change uses the correct
method to add `{"KUBECONFIG": ""}` to the existing configuration
instead of overwriting the whole AZ configuration.

This was missed when I rebased
yugabyte#8371 against latest
changes.

Fixes yugabyte#10860

Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
@bhavin192 bhavin192 mentioned this issue Dec 22, 2021
Merged
bhavin192 added a commit that referenced this issue Feb 10, 2022
@bhavin192
[Platform][Kubernetes] Use az.updateConfig for incluster credentials (#…
42d85c4 
…10928)

c0b9786 changed the behavior of
az.setConfig and added az.updateConfig. This change uses the correct
method to add `{"KUBECONFIG": ""}` to the existing configuration
instead of overwriting the whole AZ configuration.

This was missed when I rebased
#8371 against latest
changes.

Fixes #10860

Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Mar 8, 2022
@bhavin192
[Platform][Kubernetes] Use az.updateConfig for incluster credentials (y…
435a47f 
…ugabyte#10928)

c0b9786 changed the behavior of
az.setConfig and added az.updateConfig. This change uses the correct
method to add `{"KUBECONFIG": ""}` to the existing configuration
instead of overwriting the whole AZ configuration.

This was missed when I rebased
yugabyte#8371 against latest
changes.

Fixes yugabyte#10860

Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kubernetes Kubernetes support and deployments. area/platform Yugabyte Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Platform][Kubernetes] Use az.updateConfig for incluster credentials bhavin192/yugabyte-db
1 participant
@bhavin192