Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geo: Use version number instead of hash for indicating updates to transaction tables #11402

Closed
es1024 opened this issue Feb 9, 2022 · 0 comments
Closed

geo: Use version number instead of hash for indicating updates to transaction tables #11402

es1024 opened this issue Feb 9, 2022 · 0 comments
Assignees
@es1024
Labels
area/docdb YugabyteDB core features

Comments

@es1024
Copy link
Contributor

es1024 commented Feb 9, 2022

Description

Context: #9980

We currently calculate a transaction table version hash over transaction table ids and schema versions to indicate to tservers that a change in transaction tables has occurred and that a refresh of the transaction tablet cache is needed, but in the event of a hash collision, we end up not refreshing the cache. This should be changed to use a version number maintained by the master to ensure all changes are always followed by a cache refresh.
@es1024 es1024 added the area/docdb YugabyteDB core features label Feb 9, 2022
@es1024 es1024 self-assigned this Feb 9, 2022
es1024 added a commit that referenced this issue Feb 16, 2022
@es1024
[#11402] geo: Use version number instead of hash for indicating updat…
50941ff 
…es to transaction tables

Summary:
Replaced transaction status version hash + TS-local transaction status versions with
a single global transaction tables version maintained by master, to remove the possibility of
hash conflicts resulting in tablet servers not updating the transaction status tablet cache when
needed.

Depends on D14255

Test Plan: `ybd --cxx-test pgwrapper_geo_transactions-test`

Reviewers: bogdan, sergei

Reviewed By: sergei

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D15388
@es1024 es1024 closed this as completed Feb 16, 2022
@es1024 es1024 mentioned this issue Feb 17, 2022
Closed
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Mar 8, 2022
@es1024
[yugabyte#11402] geo: Use version number instead of hash for indicati…
8bc9b9f 
…ng updates to transaction tables

Summary:
Replaced transaction status version hash + TS-local transaction status versions with
a single global transaction tables version maintained by master, to remove the possibility of
hash conflicts resulting in tablet servers not updating the transaction status tablet cache when
needed.

Depends on D14255

Test Plan: `ybd --cxx-test pgwrapper_geo_transactions-test`

Reviewers: bogdan, sergei

Reviewed By: sergei

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D15388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@es1024 es1024

Labels
area/docdb YugabyteDB core features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@es1024