Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Tablet split manager should check if parent tablet is not tracked by task #11437

Closed
SrivastavaAnubhav opened this issue Feb 10, 2022 · 1 comment
Closed

[DocDB] Tablet split manager should check if parent tablet is not tracked by task #11437

SrivastavaAnubhav opened this issue Feb 10, 2022 · 1 comment
Assignees
@SrivastavaAnubhav
Labels
area/docdb YugabyteDB core features

Comments

@SrivastavaAnubhav
Copy link
Contributor

Description

The tablet split manager should check that a parent tablet is not already tracked by a task before trying to add it to the set of splits to schedule or the set of compacting splits.
@SrivastavaAnubhav SrivastavaAnubhav added the area/docdb YugabyteDB core features label Feb 10, 2022
@SrivastavaAnubhav SrivastavaAnubhav self-assigned this Feb 10, 2022
SrivastavaAnubhav added a commit that referenced this issue Feb 12, 2022
@SrivastavaAnubhav
[#11437] docdb: Verify parent tablet is not tracked by task before ad…
a95882f 
…ding to compacting or scheduled splits.

Summary: Fix for bug where we don't check splits_with_task for parent id. This can cause double-counting of splits (once in splits_with_task and once in compacting_splits or splits_to_schedule), which can slow down automatic tablet splitting. Add some tracing logging (which should not result in more than 2 * FLAGS_outstanding_tablet_split_limit lines per tablet splitting run). Inline FindSplitsWithTask and remove function.

Test Plan: ybd --cxx-test integration-tests_tablet-split-itest --gtest_filter AutomaticTabletSplitITest.*

Reviewers: rsami

Reviewed By: rsami

Subscribers: ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D15397
@SrivastavaAnubhav
Copy link
Contributor Author

Fixed by a95882f.

SrivastavaAnubhav added a commit that referenced this issue Mar 4, 2022
@SrivastavaAnubhav
[BACKPORT 2.12][#11437] docdb: Verify parent tablet is not tracked by…
7c56f22 
… task before adding to compacting or scheduled splits.

Summary:
Original commit: a95882f / D15397
Fix for bug where we don't check splits_with_task for parent id. This can cause double-counting of splits (once in splits_with_task and once in compacting_splits or splits_to_schedule), which can slow down automatic tablet splitting. Add some tracing logging (which should not result in more than 2 * FLAGS_outstanding_tablet_split_limit lines per tablet splitting run). Inline FindSplitsWithTask and remove function.

Test Plan: ybd --cxx-test integration-tests_tablet-split-itest --gtest_filter AutomaticTabletSplitITest.*

Reviewers: rsami

Reviewed By: rsami

Subscribers: bogdan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D15690
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Mar 8, 2022
@SrivastavaAnubhav
[yugabyte#11437] docdb: Verify parent tablet is not tracked by task b…
bd6ec19 
…efore adding to compacting or scheduled splits.

Summary: Fix for bug where we don't check splits_with_task for parent id. This can cause double-counting of splits (once in splits_with_task and once in compacting_splits or splits_to_schedule), which can slow down automatic tablet splitting. Add some tracing logging (which should not result in more than 2 * FLAGS_outstanding_tablet_split_limit lines per tablet splitting run). Inline FindSplitsWithTask and remove function.

Test Plan: ybd --cxx-test integration-tests_tablet-split-itest --gtest_filter AutomaticTabletSplitITest.*

Reviewers: rsami

Reviewed By: rsami

Subscribers: ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D15397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SrivastavaAnubhav SrivastavaAnubhav

Labels
area/docdb YugabyteDB core features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SrivastavaAnubhav