Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] SnapshotTest.CreateSnapshot flaky in master #11469

Closed
spolitov opened this issue Feb 13, 2022 · 0 comments
Closed

[DocDB] SnapshotTest.CreateSnapshot flaky in master #11469

spolitov opened this issue Feb 13, 2022 · 0 comments
Assignees
@spolitov
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@spolitov
Copy link
Contributor

spolitov commented Feb 13, 2022 •
edited by yugabyte-ci
Loading

Jira Link: DB-783

Description

SnapshotTest.CreateSnapshot fails periodically in various builds
@spolitov spolitov added the area/docdb YugabyteDB core features label Feb 13, 2022
@spolitov spolitov self-assigned this Feb 13, 2022
spolitov added a commit that referenced this issue Feb 15, 2022
@spolitov
[#11469] DocDB: Fix SnapshotTest.CreateSnapshot
32db69f 
Summary:
The test starts snapshot creating and check that there is snapshot with appropriate id in creating state.
Sometimes snapshot completes before this check, so it fails.
Removed this check, since it is incorrect. It is enough to check that snapshot was successfully complete later in test.

Also replaced raw snapsot id manipulations with decoding to TxnSnapshotId.
So logs would look better.

Test Plan: ybd --gtest_filter SnapshotTest.CreateSnapshot -n 200

Reviewers: oleg

Reviewed By: oleg

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D15432
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Mar 8, 2022
@spolitov
[yugabyte#11469] DocDB: Fix SnapshotTest.CreateSnapshot
763fbfd 
Summary:
The test starts snapshot creating and check that there is snapshot with appropriate id in creating state.
Sometimes snapshot completes before this check, so it fails.
Removed this check, since it is incorrect. It is enough to check that snapshot was successfully complete later in test.

Also replaced raw snapsot id manipulations with decoding to TxnSnapshotId.
So logs would look better.

Test Plan: ybd --gtest_filter SnapshotTest.CreateSnapshot -n 200

Reviewers: oleg

Reviewed By: oleg

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D15432
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spolitov @yugabyte-ci