Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Phase 2][DocDB] PITR: Support for Tablegroups #11924

Closed
sanketkedia opened this issue Mar 30, 2022 · 0 comments
Closed

[Phase 2][DocDB] PITR: Support for Tablegroups #11924

sanketkedia opened this issue Mar 30, 2022 · 0 comments
Assignees
@msun07
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
PITR Colocation

Comments

@sanketkedia
Copy link
Contributor

sanketkedia commented Mar 30, 2022 •
edited by jira bot

Jira Link: [DB-395](https://yugabyte.atlassian.net/browse/DB-395)

Description

After introducing support for colocated databases via commit, we should also add PITR support for table groups. In particular, we should add support for dropping the parent colocated tablet (since in colocated databases, the tablet is created at a database level and we don't allow dropping a PITR tracked database). We should also investigate and add other changes to support tablegroups.
@sanketkedia sanketkedia added the area/docdb YugabyteDB core features label Mar 30, 2022
@sanketkedia sanketkedia self-assigned this Mar 30, 2022
@sanketkedia sanketkedia added this to To do in PITR via automation Mar 30, 2022
@sanketkedia sanketkedia mentioned this issue Mar 30, 2022
Closed
@tverona1 tverona1 mentioned this issue Apr 26, 2022
Open
@tverona1 tverona1 added this to To do in Colocation via automation May 13, 2022
@tverona1 tverona1 changed the title [DocDB] PITR: Support for Tablegroups [Phase 2][DocDB] PITR: Support for Tablegroups May 17, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels May 17, 2022
@yugabyte-ci yugabyte-ci assigned msun07 and unassigned sanketkedia Aug 15, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Aug 23, 2022
msun07 added a commit that referenced this issue Sep 23, 2022
@msun07
[#11924, #14104] DocDB: PITR - Support for Tablegroups
98980ce 
Summary:
The diff adds PITR support for tablegroups. In particular, dropping the tablegroup parent tablet is supported.
It adds tablegroup GC tests and parameterizes the existing test cases to verify Ysql tablegroup PITR.

Check failed during catalog loading also gets fixed by adding tablegroup map cleanup logic.

Test Plan:
ybd --cxx-test yb-admin-snapshot-schedule-test

ybd --cxx-test snapshot-schedule-test --gtest_filter SnapshotScheduleTest.TablegroupGC
ybd --cxx-test yb-admin-snapshot-schedule-test --gtest_filter Colocation/YbAdminSnapshotScheduleTestWithYsqlParam.*

Reviewers: alex, zdrudi, skedia

Reviewed By: alex, zdrudi, skedia

Subscribers: ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D19398
Colocation automation moved this from To do to Done Sep 23, 2022
PITR automation moved this from To do to Done Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msun07 msun07

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
Colocation
Done
PITR
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sanketkedia @yugabyte-ci @msun07