Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geo: Put use of local transaction tables for YCQL behind gflag #12661

Closed
es1024 opened this issue May 26, 2022 · 1 comment
Closed

geo: Put use of local transaction tables for YCQL behind gflag #12661

es1024 opened this issue May 26, 2022 · 1 comment
Assignees
@es1024
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
Row Level Geo Partitioning

Comments

@es1024
Copy link
Contributor

es1024 commented May 26, 2022 •
edited by yugabyte-ci

Jira Link: DB-554

Description

Context: #9980

Use of local transaction tables for YCQL should be put behind a gflag instead of being hard-coded to always use global.
@es1024 es1024 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels May 26, 2022
@es1024 es1024 self-assigned this May 26, 2022
@es1024 es1024 added this to To Do in Row Level Geo Partitioning via automation May 26, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels May 26, 2022
es1024 added a commit that referenced this issue May 26, 2022
@es1024
[#12661] geo: Put use of local transaction tables for YCQL behind gflag
b81f295 
Summary:
This diff changes YCQL transactions from always forcing global transactions to
potentially using local transaction tables, depending on the value of the newly added
`ycql_use_local_transaction_tables` flag (default false).

Also fixes a bug when promotion can run before the transaction is ready (which never
came up for YSQL because YSQL transactions always perform a local write before
promotion).

Test Plan: `ybd --gtest_filter CqlGeoTransactionTest.TestTransactionTabletSelection`

Reviewers: sergei

Reviewed By: sergei

Subscribers: bogdan, rthallam, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D17217
@es1024
Copy link
Contributor Author

es1024 commented May 26, 2022

Added with b81f295.

@es1024 es1024 closed this as completed May 26, 2022
Row Level Geo Partitioning automation moved this from To Do to Done May 26, 2022
es1024 added a commit that referenced this issue May 26, 2022
@es1024
[BACKPORT 2.14][#12661] geo: Put use of local transaction tables for …
0a2b30e 
…YCQL behind gflag

Summary:
This diff changes YCQL transactions from always forcing global transactions to
potentially using local transaction tables, depending on the value of the newly added
`ycql_use_local_transaction_tables` flag (default false).

Also fixes a bug when promotion can run before the transaction is ready (which never
came up for YSQL because YSQL transactions always perform a local write before
promotion).

Original commit: b81f295 / D17217

Test Plan:
Jenkins: rebase 2.14

`ybd --gtest_filter CqlGeoTransactionTest.TestTransactionTabletSelection`

Reviewers: sergei, rthallam

Reviewed By: rthallam

Subscribers: ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D17233
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@es1024 es1024

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
Row Level Geo Partitioning
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@es1024 @yugabyte-ci