Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DST] Unblock transactions waiting on operations from rolled-back subtransactions #13590

Closed
pkj415 opened this issue Aug 11, 2022 · 0 comments
Closed

[DST] Unblock transactions waiting on operations from rolled-back subtransactions #13590

pkj415 opened this issue Aug 11, 2022 · 0 comments
Assignees
@robertsami
Labels
area/docdb YugabyteDB core features area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue
Projects
Wait-Queue Based Locking

Comments

@pkj415
Copy link
Contributor

pkj415 commented Aug 11, 2022 •
edited by yugabyte-ci

Jira Link: DB-3165

Description

With the basic implementation of wait queues done as part of dc81106, a waiting
transaction would need to wait for the whole blocking transaction to resolve. But a waiting transaction should be able to proceed as soon as the operation blocking it is rolled back as part of a sub-transaction rollback.
@pkj415 pkj415 added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Aug 11, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Aug 11, 2022
@pkj415 pkj415 mentioned this issue Aug 11, 2022
Closed
@yugabyte-ci yugabyte-ci added area/docdb YugabyteDB core features and removed status/awaiting-triage Issue awaiting triage labels Sep 6, 2022
robertsami added a commit that referenced this issue Sep 13, 2022
@robertsami
[#13590] dst: Unblock transactions waiting on operations from rolled-…
ce2774d 
…back subtransactions

Summary:
This revision modifies conflict resolution to ensure that waiting transactions can unblock if they
were blocked on writes from subtransactions which are rolled back. Previously the waiting
transaction would need to wait for the whole transaction to resolve. Now the waiting transaction can
proceed as soon as the operation blocking it is rolled back as part of a subtransaction rollback.

Test Plan: ybd --cxx-test pgwrapper_pg_pessimistic_locking-test --gtest_filter "PgPessimisticLockingTest.TestDeadlockTwoTransactions"

Reviewers: mbautin, sergei, pjain

Reviewed By: sergei, pjain

Subscribers: rthallam

Differential Revision: https://phabricator.dev.yugabyte.com/D18521
@robertsami robertsami added this to To do in Wait-Queue Based Locking via automation Dec 8, 2022
@robertsami robertsami moved this from To do to Done in Wait-Queue Based Locking Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertsami robertsami

Labels
area/docdb YugabyteDB core features area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue
Projects
Wait-Queue Based Locking
Status: Done
Wait-Queue Based Locking
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robertsami @pkj415 @yugabyte-ci