Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] Support batched nested loop joins on clauses that have expressions on the outer variables #14069

Closed
tanujnay112 opened this issue Sep 19, 2022 · 0 comments
Assignees
Labels
area/ysql Yugabyte SQL (YSQL) kind/new-feature This is a request for a completely new feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@tanujnay112
Copy link
Contributor

tanujnay112 commented Sep 19, 2022

Jira Link: DB-3563

Description

We currently don't support batched nested loop joins on clauses that have expressions on the outer table of the form inner_table.c1 = f(outer_table.c1, outer_table.c2, ...). This issue tracks the effort to extending BNL support to these clauses.

@tanujnay112 tanujnay112 added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Sep 19, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Sep 19, 2022
@tanujnay112 tanujnay112 self-assigned this Sep 19, 2022
@yugabyte-ci yugabyte-ci added kind/new-feature This is a request for a completely new feature and removed kind/bug This issue is a bug labels Sep 19, 2022
tanujnay112 added a commit that referenced this issue Oct 10, 2022
…expressions on outer variables

Summary:
This revision allows batching on nested loop join clauses that take the form `inner_var = f(outer_var1, outer_var2...)` for an expression `f`.

This was mainly achieved by allowing the tuplehash table in execGrouping.c to also compute hashes on expressions of input tuples as opposed to just its attributes.

Test Plan: ./yb_build.sh release --java-test 'org.yb.pgsql.TestPgRegressJoin'

Reviewers: mtakahara, amartsinchyk

Reviewed By: mtakahara, amartsinchyk

Subscribers: yql, smishra

Differential Revision: https://phabricator.dev.yugabyte.com/D20060
tanujnay112 pushed a commit that referenced this issue Jun 27, 2023
…at have expressions on outer variables"

This reverts commit a1a5160.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/new-feature This is a request for a completely new feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Development

No branches or pull requests

2 participants