-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docdb][metrics] Add metrics for number of running flushes/compactions #1805
Comments
We currently graph these in YW: managed/src/main/resources/metrics.yml
With the additional pause/resume mechanic, there's a couple of interesting things to consider:
Passing this to @rajukumaryb as he's already looking at some rocksdb work. |
This one is a bit less well described and we should figure out which metrics make sense. So far, I noted 3 categories above, which in turn should be split by compactions that are active vs paused (ie: pre-empted)
The priority thread pool implementation is For metrics usage, you can search for examples using Good people references: @spolitov and @jmeehan16 |
@arybochkin I put this on the backburner for now, to switch into some tablet splitting work |
…tes split by active, paused, and queued. Summary: Added 9 new metrics for compaction tasks, files and bytes split by active, paused, and queued. Test Plan: Used curl -q http://127.0.0.1:9000/prometheus-metrics to observe the metrics updating during compactions, and reverting back to 0 afterwards. Reviewers: timur, rsami, jmeehan Reviewed By: jmeehan Subscribers: jenkins-bot, ybase, bogdan Differential Revision: https://phabricator.dev.yugabyte.com/D15005
…, and bytes split by active, paused, and queued. Summary: Added 9 new metrics for compaction tasks, files and bytes split by active, paused, and queued. Test Plan: Used curl -q http://127.0.0.1:9000/prometheus-metrics to observe the metrics updating during compactions, and reverting back to 0 afterwards. Reviewers: timur, rsami, jmeehan Reviewed By: jmeehan Subscribers: jenkins-bot, ybase, bogdan Differential Revision: https://phabricator.dev.yugabyte.com/D15005
Now that we have the new PriorityPool for flushes and compactions, we should add specific metrics, split by type (flushes, small/large compactions):
The text was updated successfully, but these errors were encountered: