Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL][Query Diagnostics] Flush Mechanism #22153

Closed
1 task done
Tracked by #22155
IshanChhangani opened this issue Apr 25, 2024 · 0 comments
Closed
1 task done
Tracked by #22155

[YSQL][Query Diagnostics] Flush Mechanism #22153

IshanChhangani opened this issue Apr 25, 2024 · 0 comments
Assignees
@IshanChhangani
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@IshanChhangani
Copy link
Contributor

IshanChhangani commented Apr 25, 2024 •
edited by jira bot
Loading

Jira Link: DB-11081

Description

This issue adds the functionality of dumping the query_diagnostics bundle data into the disk using periodic flushing.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@IshanChhangani IshanChhangani added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Apr 25, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Apr 25, 2024
@IshanChhangani IshanChhangani mentioned this issue Apr 25, 2024
Open
11 tasks
@hbhanawat hbhanawat removed the status/awaiting-triage Issue awaiting triage label Apr 25, 2024
IshanChhangani added a commit that referenced this issue Oct 25, 2024
@IshanChhangani
[#22153] YSQL, QueryDiagnostics: Add regular flushing mechanism.
0c5ae28 
Summary:
- There exists hard limits on file sizes which are to be dumped as part of each bundle and thereby on amount of data that can be diagnosed.
- Current diff adds regular flushing functionality thereby removing the limits on data capture.
- Background worker checks if any of the shared variables that are meant to be dumped have touched half of their limit, then it dumps that much data to the file system and empties the variable.
- Current diff also adds a limit of 1 KB on pgss query string.
Jira: DB-11081

Test Plan: Jenkins: test regex: .*TestYbQueryDiagnostics[.](testYbQueryDiagnosticsStatus|testIntermediateFlushing).*

Reviewers: asaha, telgersma

Reviewed By: telgersma

Subscribers: svc_phabricator, yql

Differential Revision: https://phorge.dev.yugabyte.com/D37932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IshanChhangani IshanChhangani

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hbhanawat @yugabyte-ci @IshanChhangani