Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yugabyted] For pg parity feature, make changes to remove sized based fetching and add bitmap scans. #23777

Closed
1 task done
nchandrappa opened this issue Sep 3, 2024 · 0 comments
Assignees
Labels
area/ecosystem Label for all ecosystem related projects kind/enhancement This is an enhancement of an existing feature priority/high High Priority

Comments

@nchandrappa
Copy link
Contributor

nchandrappa commented Sep 3, 2024

Jira Link: DB-12683

Description

The configuration changes will be:

Remove/Unset GUCs (from the pg parity config not DB code/product):

yb_fetch_row_limit=0
yb_fetch_size_limit=1MB

Add/Set GUC (to the pg parity config, it's already available in the DB code/product):

yb_enable_bitmapscan=true

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@nchandrappa nchandrappa added area/ecosystem Label for all ecosystem related projects status/awaiting-triage Issue awaiting triage area/ybd yugabyted project related Github tickets. labels Sep 3, 2024
@nchandrappa nchandrappa self-assigned this Sep 3, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue priority/high High Priority and removed status/awaiting-triage Issue awaiting triage area/ybd yugabyted project related Github tickets. priority/medium Medium priority issue labels Sep 3, 2024
nchandrappa added a commit that referenced this issue Sep 4, 2024
…sed fetching and add bitmap scans.

Summary:
Removed yb_fetch_row_limit=0, yb_fetch_size_limit=1MB and included yb_enable_bitmapscan=true.
Jira: DB-12683

Test Plan: Manual Tests

Reviewers: djiang

Reviewed By: djiang

Subscribers: yugabyted-dev

Differential Revision: https://phorge.dev.yugabyte.com/D37748
jasonyb pushed a commit that referenced this issue Sep 5, 2024
Summary:
 f8049b8 [doc][xcluster][2024.1.2] Semi-automatic transactional xCluster (#23710)
 f2c8470 [docs][yugabyted][2024.1.2] Add Read Replica and xCluster examples (#23289)
 ea3157c [doc][yba][2024.1.2] Export database audit logs (#23605)
 Excluded: 8bae488 [#18822] YSQL: Write out unmodified cols to main table when update optimizations are enabled
 5012632 [PLAT-15152] Upgrade YBC client and server version to 2.2.0.0-b5
 cccb1e1 Fix YCQL index table workflow in docs (#23774)
 9a3f5f7 [PLAT-15028] yba installer simplify postgres initdb
 a2b5e72 [docs] Release notes for 2024.1.2.0 (#23679)
 9a9690d Fix 2024.1.2 build number (#23779)
 aec361b [doc] Voyager 1.8 (#23764)
 a2540e0 [DEVOPS-3185, DEVOPS-3114] Bump up frozen pip modules to latest versions compatible with py3.8
 88f23dd [docs] [xcluster] Add min version for semi-automatic mode (#23776)
 1d61e67 Revise the entire assessment page (#23784)
 142c04a [PLAT-15089] HA sync immediately after promotion
 315110f [PLAT-15132][PLAT-15153] Allow users to configure logging level for YNP, also minor bug fixes
 82ff8d1 [PLAT-6779] Handle relative paths in yb_platform_backup.sh
 Excluded: 45c9cf8 [#23263] YSQL, ASH: Instrument more wait states
 Excluded: 9f8acff [#22148] YSQL, QueryDiagnostics:  Adding support for Ash data.
 39670e8 download links (#23790)
 2674a79 [#23780] YSQL: Modify catalog version mismatch test assertions with Connection Manager enabled
 3eb31b8 [#23777] yugabyted: update the gflags of pg parity to remove sized based fetching and add bitmap scans.
 fc5accd [docs] Enclose `allowed_preview_flags_csv` CSV parameters in brackets (#23758)

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Differential Revision: https://phorge.dev.yugabyte.com/D37772
nchandrappa added a commit that referenced this issue Sep 5, 2024
…w gflags enabled for the pg parity feature.

Summary:
Updating the pg parity testcase to remove size based fetching gflags and including gflag to enable bitmap scans.
Jira: DB-12683

Test Plan: ./yb_build.sh --java-test 'org.yb.yugabyted.TestYugabytedPgParity.testPgParity'

Reviewers: djiang

Reviewed By: djiang

Subscribers: yugabyted-dev

Differential Revision: https://phorge.dev.yugabyte.com/D37783
jasonyb pushed a commit that referenced this issue Sep 6, 2024
Summary:
 c587efd [docs] minor edit (#23796)
 31e09f3 [PLAT-15029] yba installer split data and software directory setup
 f5ba17d [PLAT-15039]: Fix bootstrap on bi-directional xCluster config creation
 578248a [#23770] YSQL: Deterministically populate catalog cache in tests with Connection Manager enabled
 7b1f22a [#23799] test: Fixed PgTableSizeTest.SharedTableSize test for pg15
 788434a [#18771, #21352] docdb: Fix LightweightMessage max size when parsing
 02ced43 [#22821] YSQL: Preserve local limit in a multi-page read
 50ff737 [#23741] docdb: Fix cloning of colocated databases with only parent table
 Excluded: 9889df7 [#23706] YSQL: Add table-level catcache Prometheus metrics
 c770d79 [#23747] MetaCache: Callback should not be called while holding the lock
 Excluded: 40689bc [#22150] YSQL, QueryDiagnostics:  EXPLAIN (ANALYZE, DIST) support for queryDiagnostics
 1655e69 [PLAT-15148]: Set XCluster Table Status to DroppedFromTarget if table in replication is dropped from target only
 16262f7 [#22519] YSQL: Simplify API of the ExplicitRowLockBuffer class
 6614afb [PLAT-14958][PLAT-14959] Make ssh fields optional if skipProvisioning is true
 1153b56 [PLAT-14867] Make sure restart alerts don't trigger for small time updates during NTP sync
 bf1c7bc [PLAT-12226] Add connection pooling status to universe health check
 38d8ae8 [PLAT-14805]Support adding EAR configs
 a180bef [#19134] YSQL, ASH: Setting ASH circular buffer size based on the number of cores
 7d8fc76 Adjust heading link (#23807)
 4c6cf5a [PLAT-4899]Basic validation of certificates
 f24eb10 [#23787] YSQL: Avoid executing conn mgr guc variables hooks for parallel workers
 ee18df8 [PLAT-13921] [K8] [UI] Universe action tasks are disabled after a failed shrink rr node task
 Excluded: dcf1821 [#23797] YSQL: Modify some tests to run in single connection mode with Connection Manager
 0ac22cd [Docs] Remove Drift chat bot (#23802)
 0e91003 [#22825] DocDB: Vector Index General Read Path with DummyANN
 e8f09b5 [PLAT-15175] Make runtime conf for skipping cluster consistency check public
 ee479ee Versionwarning (#23781)
 a05c6a3 [DB-12681] yugabyted-ui: Add Voyager commands to different Voyager phases in the UI.
 cc80d59 [#23777] yugabyted: updating the pg parity testcase to reflect the new gflags enabled for the pg parity feature.

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D37822
nchandrappa added a commit that referenced this issue Sep 9, 2024
…o remove sized based fetching and add bitmap scans.

Summary:
Original commit: 3eb31b8 / D37748
Removed yb_fetch_row_limit=0, yb_fetch_size_limit=1MB and included yb_enable_bitmapscan=true.
Jira: DB-12683

Test Plan: Manual Tests

Reviewers: djiang

Reviewed By: djiang

Subscribers: yugabyted-dev

Differential Revision: https://phorge.dev.yugabyte.com/D37914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ecosystem Label for all ecosystem related projects kind/enhancement This is an enhancement of an existing feature priority/high High Priority
Projects
None yet
Development

No branches or pull requests

2 participants