Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Simplify ExecLockRows code #25268

Closed
1 task done
d-uspenskiy opened this issue Dec 12, 2024 · 0 comments
Closed
1 task done

[YSQL] Simplify ExecLockRows code #25268

d-uspenskiy opened this issue Dec 12, 2024 · 0 comments
Assignees
@d-uspenskiy
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@d-uspenskiy
Copy link
Contributor

d-uspenskiy commented Dec 12, 2024 •
edited by jira bot
Loading

Jira Link: DB-14457

Description

The ExecLockRows function has the code to check that row locks are not requested for YB and non-YB tables at same time. It is reasonable to move this code into initialization step of the Lock Rows node to avoid wasting of CPU cycles on each row processing.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@d-uspenskiy d-uspenskiy added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Dec 12, 2024
@d-uspenskiy d-uspenskiy self-assigned this Dec 12, 2024
@d-uspenskiy d-uspenskiy added this to YSQL Dec 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in YSQL Dec 12, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Dec 12, 2024
d-uspenskiy added a commit that referenced this issue Dec 18, 2024
@d-uspenskiy
[#25268] YSQL: Simplify ExecLockRows code
39088f7 
Summary:
The `ExecLockRows` function has the code to check that row locks are not requested for YB and non-YB tables at same time. It is reasonable to move this code into initialization step of the  Lock Rows node to avoid wasting of CPU cycles on each row processing.
Jira: DB-14457

Test Plan: Jenkins

Reviewers: pjain

Reviewed By: pjain

Subscribers: yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D40632
@github-project-automation github-project-automation bot moved this from Backlog to Done in YSQL Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-uspenskiy d-uspenskiy

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
YSQL
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @d-uspenskiy