[YW] Running a backup sometimes causes TaskProgressStepbar to flicker on screen #3429
Assignees
Labels
Comments
andrewc-dev
pushed a commit
to andrewc-dev/yugabyte-db
that referenced
this issue
Jan 24, 2020
…se tables and remove border from TaskProgress
Summary:
Add additional check whether tables have been already fetched before calling API to fetch
tables. Remove border from TaskProgress because it was distracting and caused the spacing to look
strange.
Test Plan:
Create a backup (preferably one that takes a long time), and then navigate to the
universe-level Tasks tab and check what happens to the UI. Make sure that the stepbar does not do
any flickering.
*One symptom of the incorrect code was that a TON of network requests were being made and causing the UI to lag*
I recommend connecting local YW to customer's environment to repro. After tunneling, you can add the url to .env with `REACT_APP_YUGAWARE_API_URL=http://localhost:8080/api`
Example of fixed UI:
{F13140}
Reviewers: wesley, arnav, ram
Reviewed By: ram
Subscribers: kannan, rao, ui
Differential Revision: https://phabricator.dev.yugabyte.com/D7831
andrewc-dev
added a commit
that referenced
this issue
Jan 24, 2020
…s and remove border from TaskProgress (#3440) Summary: Add additional check whether tables have been already fetched before calling API to fetch tables. Remove border from TaskProgress because it was distracting and caused the spacing to look strange. Test Plan: Create a backup (preferably one that takes a long time), and then navigate to the universe-level Tasks tab and check what happens to the UI. Make sure that the stepbar does not do any flickering. *One symptom of the incorrect code was that a TON of network requests were being made and causing the UI to lag* I recommend connecting local YW to customer's environment to repro. After tunneling, you can add the url to .env with `REACT_APP_YUGAWARE_API_URL=http://localhost:8080/api` Example of fixed UI: {F13140} Reviewers: wesley, arnav, ram Reviewed By: ram Subscribers: kannan, rao, ui Differential Revision: https://phabricator.dev.yugabyte.com/D7831
andrewc-dev
added a commit
that referenced
this issue
Jan 24, 2020
…s and remove border from TaskProgress (#3440) Summary: Add additional check whether tables have been already fetched before calling API to fetch tables. Remove border from TaskProgress because it was distracting and caused the spacing to look strange. Test Plan: Create a backup (preferably one that takes a long time), and then navigate to the universe-level Tasks tab and check what happens to the UI. Make sure that the stepbar does not do any flickering. *One symptom of the incorrect code was that a TON of network requests were being made and causing the UI to lag* I recommend connecting local YW to customer's environment to repro. After tunneling, you can add the url to .env with `REACT_APP_YUGAWARE_API_URL=http://localhost:8080/api` Example of fixed UI: {F13140} Reviewers: wesley, arnav, ram Reviewed By: ram Subscribers: kannan, rao, ui Differential Revision: https://phabricator.dev.yugabyte.com/D7831
|
@yb-andrew can we close this issue? |
carlos-username
pushed a commit
to carlos-username/yugabyte-db
that referenced
this issue
Mar 11, 2020
…se tables and remove border from TaskProgress (yugabyte#3440) Summary: Add additional check whether tables have been already fetched before calling API to fetch tables. Remove border from TaskProgress because it was distracting and caused the spacing to look strange. Test Plan: Create a backup (preferably one that takes a long time), and then navigate to the universe-level Tasks tab and check what happens to the UI. Make sure that the stepbar does not do any flickering. *One symptom of the incorrect code was that a TON of network requests were being made and causing the UI to lag* I recommend connecting local YW to customer's environment to repro. After tunneling, you can add the url to .env with `REACT_APP_YUGAWARE_API_URL=http://localhost:8080/api` Example of fixed UI: {F13140} Reviewers: wesley, arnav, ram Reviewed By: ram Subscribers: kannan, rao, ui Differential Revision: https://phabricator.dev.yugabyte.com/D7831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Create a backup and go to the universe-level Tasks tab and see what happens visually. The TaskProgressStepbar appears above the Task History table and flickers briefly then goes away.
The text was updated successfully, but these errors were encountered: