Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Support renaming constraints in ALTER TABLE #3943

Closed
ndeodhar opened this issue Mar 12, 2020 · 4 comments
Closed

[YSQL] Support renaming constraints in ALTER TABLE #3943

ndeodhar opened this issue Mar 12, 2020 · 4 comments
Labels
area/ysql Yugabyte SQL (YSQL) good first issue This is a good issue to start contributing! help wanted We welcome your contributions for this issue! kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@ndeodhar
Copy link
Contributor

ndeodhar commented Mar 12, 2020 •
edited by yugabyte-ci

Jira Link: DB-1574
Add support for ALTER TABLE name RENAME CONSTRAINT
@ndeodhar ndeodhar added help wanted We welcome your contributions for this issue! good first issue This is a good issue to start contributing! area/ysql Yugabyte SQL (YSQL) labels Mar 12, 2020
@ndeodhar ndeodhar self-assigned this Mar 12, 2020
@nocaway nocaway mentioned this issue Mar 12, 2020
Open
@ndeodhar ndeodhar removed their assignment May 20, 2020
@hiepd
Copy link
Contributor

hiepd commented Jul 23, 2020

@ndeodhar Would like to look at this issue if it's still open. From the master issue, it seems that this is done. Thanks!

@ndeodhar
Copy link
Contributor Author

Hi @hiepd , thanks for your interest in contributing! This is still available (there was a mistake in the master issue, corrected it now). Please assign this to yourself if you plan to pick this up.

Would be great if you can enable these two flavors:
ALTER TABLE tablename RENAME CONSTRAINT oldname TO newname
ALTER TABLE IF EXISTS tablename RENAME CONSTRAINT oldname TO newname

@devabhishekpal
Copy link

Hey... I wanted to work on this issue if I could be pointed to which file I need to start digging into

@lukaseder
Copy link

Note that when trying to run this statement, this issue isn't referenced yet as for other not yet supported syntax. Instead, the error message suggests creating a new issue:

SQL Error [0A000]: ERROR: ALTER TABLE RENAME CONSTRAINT not supported yet
  Hint: Please report the issue on https://github.com/YugaByte/yugabyte-db/issues
  Position: 1

@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 8, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Oct 5, 2022
@mislam-yb mislam-yb self-assigned this Jan 13, 2023
@mislam-yb mislam-yb self-assigned this Jan 13, 2023
mislam-yb added a commit that referenced this issue Jan 25, 2023
@mislam-yb
[#3943] YSQL: Support renaming constraints
c534201 
Summary: Enable alter table statements that have "rename constraint" terms. Introduce tests for these statements update the expected output for relevant SQL regression tests.

Test Plan:
Introduce renaming constraints to alter_table test and update output accordingly. Also update output for foreign data test.

Test commands:

./yb_build.sh --scb --sj --java-test TestPgRegressTable
./yb_build.sh --scb --sj --java-test TestPgRegressForeignData

Reviewers: tverona, jason

Reviewed By: jason

Subscribers: jason

Differential Revision: https://phabricator.dev.yugabyte.com/D22258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ysql Yugabyte SQL (YSQL) good first issue This is a good issue to start contributing! help wanted We welcome your contributions for this issue! kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
YQL-beta
Status: Done
Milestone
No milestone
Development

No branches or pull requests
7 participants
@lukaseder @hiepd @m-iancu @ndeodhar @yugabyte-ci @devabhishekpal @mislam-yb