[YSQL] Support ALTER COLUMN type that does not require on-disk changes #4424
Assignees
Labels
area/ysql
Yugabyte SQL (YSQL)
Comments
hulien22
added a commit
that referenced
this issue
Aug 4, 2020
#4424) Summary: Enabling AT_AlterColumnType allowing for altering column types when they don't require on-disk changes Specifically only allowing alter column type for `varchar(n)` and `varbit(n)` types, or if no change would occur (ie setting to the exact same type). Test Plan: Added tests to `yb_feature_alter_table.sql`. Reviewers: neha, mihnea Reviewed By: mihnea Subscribers: yql Differential Revision: https://phabricator.dev.yugabyte.com/D8880
|
Closed by ac0eb93. |
hulien22
added a commit
that referenced
this issue
Aug 6, 2020
Summary: Fixing part of o.y.pg.PgForeignKey.PgRegr that was broken in commit ac0eb93. Also fixing the o.y.pg.PgRegrFeature test. Test Plan: ybd --java-test 'org.yb.pgsql.TestPgForeignKey#testPgRegress' ybd --java-test org.yb.pgsql.TestPgRegressFeature Reviewers: neha, mihnea, jason Reviewed By: jason Subscribers: yql Differential Revision: https://phabricator.dev.yugabyte.com/D9100
|
This fix addresses most commonly use variants of |
hulien22
added a commit
that referenced
this issue
Sep 2, 2020
…re on-disk changes (#4424) Summary: Enabling AT_AlterColumnType allowing for altering column types when they don't require on-disk changes Specifically only allowing alter column type for `varchar(n)` and `varbit(n)` types, or if no change would occur (ie setting to the exact same type). Test Plan: Jenkins: rebase: 2.2 Reviewers: neha, mihnea Reviewed By: mihnea Subscribers: bogdan, kannan, yql Differential Revision: https://phabricator.dev.yugabyte.com/D9233
hulien22
added a commit
that referenced
this issue
Sep 2, 2020
Summary: Fixing part of o.y.pg.PgForeignKey.PgRegr that was broken in commit ac0eb93. Also fixing the o.y.pg.PgRegrFeature test. Test Plan: Jenkins: rebase: 2.2 Reviewers: jason, mihnea Reviewed By: mihnea Subscribers: ena, yql Differential Revision: https://phabricator.dev.yugabyte.com/D9293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We don't support
ALTER COLUMN typetoday. The main reason for this is that altering data type may require changing on-disk data for existing rows. However, there are some variants that don't require on-disk changes. For example, changing column type fromvarchar(50)tovarchar(255). We should add support for such changes.The text was updated successfully, but these errors were encountered: