Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tablet splitting: Size-based strategy - detect split key for tablet #4487

Closed
ttyusupov opened this issue May 18, 2020 · 0 comments
Closed

Tablet splitting: Size-based strategy - detect split key for tablet #4487

ttyusupov opened this issue May 18, 2020 · 0 comments
Assignees
@ttyusupov
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature
Projects
YBase features Tablet splitting

Comments

@ttyusupov
Copy link
Contributor

ttyusupov commented May 18, 2020 •
edited

Parent ticket: "Tablet splitting" #1004.

Uses approximate middle doc key from the largest SST.
@ttyusupov ttyusupov added kind/enhancement This is an enhancement of an existing feature area/docdb YugabyteDB core features labels May 18, 2020
@ttyusupov ttyusupov self-assigned this May 18, 2020
@ttyusupov ttyusupov added this to To Do in YBase features via automation May 18, 2020
@ttyusupov ttyusupov moved this from To Do to In progress in YBase features May 21, 2020
@ttyusupov ttyusupov changed the title Tablet splitting: Size-based strategy - detect split keys for range-partitioned tablets Tablet splitting: Size-based strategy - detect split key for tablet Jun 11, 2020
ttyusupov added a commit that referenced this issue Jun 12, 2020
@ttyusupov
#4487: Detection of approximate middle DocKey for a tablet splitting
50a714a 
Summary:
Implementation takes middle restart point from the largest SST file index and uses next DocKey from SST file key as an approximate middle DocKey for a tablet.

Other changes:
- `BlockBasedTable::GetIndexReader` code from `BlockBasedTable::NewIndexIterator` to reuse it in `BlockBasedTable::GetMiddleKey`.
- Added `TableCache::GetTableReader`
- Added `QLTabletTest.GetMiddleKey`
- Added `BlockTest.GetMiddleKey`

Test Plan: `ybd --gtest_filter QLTabletTest.GetMiddleKey -n 100 -- -p 1`

Reviewers: sergei, mikhail, bogdan

Reviewed By: bogdan

Subscribers: raju, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D8636
YBase features automation moved this from In progress to Done Jun 12, 2020
@ttyusupov ttyusupov added this to To do in Tablet splitting via automation Jun 23, 2020
@ttyusupov ttyusupov moved this from To do to Done in Tablet splitting Jun 23, 2020
deeps1991 pushed a commit to deeps1991/yugabyte-db that referenced this issue Jul 22, 2020
@ttyusupov @deeps1991
yugabyte#4487: Detection of approximate middle DocKey for a tablet sp…
ff64e3d 
…litting

Summary:
Implementation takes middle restart point from the largest SST file index and uses next DocKey from SST file key as an approximate middle DocKey for a tablet.

Other changes:
- `BlockBasedTable::GetIndexReader` code from `BlockBasedTable::NewIndexIterator` to reuse it in `BlockBasedTable::GetMiddleKey`.
- Added `TableCache::GetTableReader`
- Added `QLTabletTest.GetMiddleKey`
- Added `BlockTest.GetMiddleKey`

Test Plan: `ybd --gtest_filter QLTabletTest.GetMiddleKey -n 100 -- -p 1`

Reviewers: sergei, mikhail, bogdan

Reviewed By: bogdan

Subscribers: raju, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D8636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttyusupov ttyusupov

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature
Projects
Tablet splitting
  
Done
YBase features
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ttyusupov