Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inaccurate compaction counters due to undersized printf #499

Closed
ajcaldera1 opened this issue Oct 9, 2018 · 0 comments
Closed

inaccurate compaction counters due to undersized printf #499

ajcaldera1 opened this issue Oct 9, 2018 · 0 comments
Assignees
@ttyusupov
Labels
kind/bug This issue is a bug

Comments

@ajcaldera1
Copy link
Contributor

/yugabyte-db/src/yb/rocksdb/db/compaction_job.cc:582

Observation #1.
T be741303c0774867bf7319b8958fbc88: [default] compacted to: files[15] max score 2.20, MB/sec: 6.8 rd, 1.0 wr, level 0, files in(0, 15) out(1) MB in(0.0, 31717.8) out(4575.9), read-write-amplify(38056773138.0) write-amplify(4798216918.0) OK, records in: -1510644558, records dropped: -1940654396
Observation #2.

I1005 10:37:47.263108 4521 compaction_job.cc:582] T be741303c0774867bf7319b8958fbc88: [default] compacted to: files[8] max score 0.80, MB/sec: 4.7 rd, 3.2 wr, level 0, files in(0, 10) out(1) MB in(0.0, 18992.7) out(12797.6), read-write-amplify(33334584156.0) write-amplify(13419265279.0) OK, records in: 1509556980(, records dropped: 2054364
@ajcaldera1 ajcaldera1 added the kind/bug This issue is a bug label Oct 9, 2018
parikhdev0 added a commit that referenced this issue Feb 24, 2022
@parikhdev0
[#499] docdb: Fixed overflow bug when printing records in during a co…
96a461b 
…mpaction.

Summary: Fixed bug where when printing number of records in and records dropped during a compaction, the number would overflow due to using %d in the print statement instead of %llu

Test Plan: Manually observed log files

Reviewers: jmeehan

Reviewed By: jmeehan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D15619
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Mar 8, 2022
@parikhdev0
[yugabyte#499] docdb: Fixed overflow bug when printing records in dur…
8221592 
…ing a compaction.

Summary: Fixed bug where when printing number of records in and records dropped during a compaction, the number would overflow due to using %d in the print statement instead of %llu

Test Plan: Manually observed log files

Reviewers: jmeehan

Reviewed By: jmeehan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D15619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttyusupov ttyusupov

Labels
kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmatican @ttyusupov @ajcaldera1