Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display xDC Lag Graph in Milliseconds instead of Microseconds #5632

Closed
rahuldesirazu opened this issue Sep 9, 2020 · 0 comments
Closed

Display xDC Lag Graph in Milliseconds instead of Microseconds #5632

rahuldesirazu opened this issue Sep 9, 2020 · 0 comments
Assignees
Labels
area/platform Yugabyte Platform kind/improve-ux Issues relating to improving user experience. platform/current
Milestone

Comments

@rahuldesirazu
Copy link
Contributor

No description provided.

@rahuldesirazu rahuldesirazu added kind/improve-ux Issues relating to improving user experience. area/platform Yugabyte Platform labels Sep 9, 2020
@rahuldesirazu rahuldesirazu self-assigned this Sep 9, 2020
@streddy-yb streddy-yb added this to the v2.3 milestone Sep 15, 2020
andrewc-dev pushed a commit that referenced this issue Sep 22, 2020
…le width of Replication graph and increase height.

Summary:
Change current `width` props to MetricsPanel into `containerWidth` which is more accurate
for what they are doing (setting the size of the container and letting the MetricsPanel component
decide the width based on how many columns there are. With this change in place, we can add a true
`width` prop that sets the size of the Plotly graph. Due to the legend being squished onto the
x-axis we also add a new `height` prop to the MetricsPanel and add some SCSS rules to accomodate the
single graph on the Replication page. The replication metric data includes data points from all
tservers, which can be difficult to display in a readable format, so we will aggregate the values
into an average and max value graph across all tservers.

Test Plan:
Go to a universe that is set up with 2dc replication. Go to the Replication tab and
confirm the data.

Example of the new replication graph. Note that the y-axis is off by a factor of 1000 because I'm running it off GCP portal which still has 2.2 changes without the divide by 1000 operator in `metrics.yaml`
{F14062}

Reviewers: rahuldesirazu, arnav, sshevchenko

Reviewed By: sshevchenko

Subscribers: jenkins-bot

Differential Revision: https://phabricator.dev.yugabyte.com/D9372
andrewc-dev pushed a commit that referenced this issue Sep 24, 2020
…le width of Replication graph and increase height.

Summary:
Change current `width` props to MetricsPanel into `containerWidth` which is more accurate
for what they are doing (setting the size of the container and letting the MetricsPanel component
decide the width based on how many columns there are. With this change in place, we can add a true
`width` prop that sets the size of the Plotly graph. Due to the legend being squished onto the
x-axis we also add a new `height` prop to the MetricsPanel and add some SCSS rules to accomodate the
single graph on the Replication page. The replication metric data includes data points from all
tservers, which can be difficult to display in a readable format, so we will aggregate the values
into an average and max value graph across all tservers.

Test Plan:
Go to a universe that is set up with 2dc replication. Go to the Replication tab and
confirm the data.

Example of the new replication graph. Note that the y-axis is off by a factor of 1000 because I'm running it off GCP portal which still has 2.2 changes without the divide by 1000 operator in `metrics.yaml`
{F14062}

Reviewers: rahuldesirazu, arnav, sshevchenko

Reviewed By: sshevchenko

Subscribers: jenkins-bot

Differential Revision: https://phabricator.dev.yugabyte.com/D9372
andrewc-dev pushed a commit that referenced this issue Sep 25, 2020
Summary:
Currently the replication graph shows numbers in the y-axis without any units. Since we are
dividing by 1000 the correct unit is milliseconds. This is a follow-up diff to commit a404039

Test Plan:
Create 2DC universes and go to consumer universe and confirm that the Replication graph
shows `ms` in the y-axis.

Reviewers: rahuldesirazu, arnav, sanketh

Reviewed By: sanketh

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D9455
andrewc-dev pushed a commit that referenced this issue Sep 25, 2020
Summary:
Currently the replication graph shows numbers in the y-axis without any units. Since we are
dividing by 1000 the correct unit is milliseconds. This is a follow-up diff to commit a404039

Test Plan:
Create 2DC universes and go to consumer universe and confirm that the Replication graph
shows `ms` in the y-axis.

Reviewers: rahuldesirazu, arnav, sanketh

Reviewed By: sanketh

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D9455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Yugabyte Platform kind/improve-ux Issues relating to improving user experience. platform/current
Projects
None yet
Development

No branches or pull requests

3 participants