Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docdb] Make post-tablet-split compaction asynchronous #6424

Closed
robertsami opened this issue Nov 19, 2020 · 0 comments
Closed

[docdb] Make post-tablet-split compaction asynchronous #6424

robertsami opened this issue Nov 19, 2020 · 0 comments
Assignees
@robertsami
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug
Projects
YBase features Tablet splitting

Comments

@robertsami
Copy link
Contributor

On tablet set-up, if the tablet is the result of a split, we trigger compaction via a RocksDB API which was previously thought to be asynchronous. However, it is in fact blocking. Thus the tablet ends up being unavailable until compaction is done, which is unnecessary
@robertsami robertsami added the area/docdb YugabyteDB core features label Nov 19, 2020
@robertsami robertsami self-assigned this Nov 19, 2020
robertsami added a commit that referenced this issue Dec 14, 2020
@robertsami
[#6424] Fix post-split compaction to be async
b408754 
Summary: Previously we were blocking on post-split tablet compaction, so tablet open could not complete. This diff modifies post-split compaction to be asynchronous.

Test Plan: `ybd --cxx-test integration-tests_tablet-split-itest --gtest_filter TabletSplitITest.SplitTabletIsAsync`

Reviewers: timur

Reviewed By: timur

Subscribers: bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D9951
@bmatican bmatican added this to To do in Tablet splitting via automation Dec 16, 2020
Tablet splitting automation moved this from To do to Done Dec 16, 2020
robertsami added a commit that referenced this issue Jan 8, 2021
@robertsami
[BACKPORT 2.4][#6424] Fix post-split compaction to be async
d26fd97 
Summary:
Previously we were blocking on post-split tablet compaction, so tablet open could not complete. This diff modifies post-split compaction to be asynchronous.

Original commit:
b408754

Test Plan:
`ybd --cxx-test integration-tests_tablet-split-itest --gtest_filter TabletSplitITest.SplitTabletIsAsync`

Jenkins: rebase: 2.4

Reviewers: timur

Reviewed By: timur

Subscribers: bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D10222
@bmatican bmatican mentioned this issue Jan 21, 2021
Closed
@ttyusupov ttyusupov added the kind/bug This issue is a bug label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertsami robertsami

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug
Projects
Tablet splitting
  
Done
YBase features
  
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmatican @ttyusupov @robertsami