Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Tablet auto splitting is still marked as BETA #6977

Closed
ddorian opened this issue Jan 22, 2021 · 7 comments · Fixed by #7013
Closed

[docs] Tablet auto splitting is still marked as BETA #6977

ddorian opened this issue Jan 22, 2021 · 7 comments · Fixed by #7013
Assignees
Labels
area/documentation Documentation needed
Milestone

Comments

@ddorian
Copy link
Contributor

ddorian commented Jan 22, 2021

Tablet autosplitting is GA but is still marked as BETA in https://docs.yugabyte.com/latest/architecture/docdb-sharding/tablet-splitting/#automatic-tablet-splitting-beta and https://docs.yugabyte.com/latest/reference/configuration/yb-master/#tablet-split-size-threshold-bytes

@ddorian ddorian added the area/documentation Documentation needed label Jan 22, 2021
@ameyb ameyb added this to the 2.4.0.0 milestone Jan 22, 2021
@lizayugabyte lizayugabyte added this to In progress in Documentation Jan 25, 2021
@lizayugabyte
Copy link
Contributor

@ddorian Just to make sure I understand: auto tablet splitting is GA and manual is Beta, correct?

@lizayugabyte
Copy link
Contributor

@ddorian Have any of the following items been resolved in 2.4 and can be removed from the limitations list? * Presplit tablets remain in the system forever and are not deleted from the disk.

  • There is no upper bound on the number of tablets for the table when automatic tablet splitting is enabled.
  • During tablet splitting, client applications can get an error from the driver and need to retry the request.
  • If tablet splitting occurs during an ongoing distributed transaction, it could be aborted and need to be retried.
  • Because splitting of tablets that are not completely compacted is not yet implemented, tablets created by tablet splitting might be split after they reach the specified size threshold.
  • Colocated tables cannot be split.

@ddorian
Copy link
Contributor Author

ddorian commented Jan 26, 2021

@mikhpolitov @robertsami @ttyusupov have committed on the feature: #1004 so they can confirm::

auto tablet splitting is GA and manual is Beta, correct?

I'm assuming manual-split is also GA @mbautin

There is no upper bound on the number of tablets for the table when automatic tablet splitting is enabled.

This is done in e028f70

During tablet splitting, client applications can get an error from the driver and need to retry the request.

This is true #5854

If tablet splitting occurs during an ongoing distributed transaction, it could be aborted and need to be retried.

This is true #5854

Because splitting of tablets that are not completely compacted is not yet implemented, tablets created by tablet splitting might be split after they reach the specified size threshold.

Fixed in #5523 @robertsami ?

Colocated tables cannot be split.

This should be true, the same as "pull out colocated tables", tracked here: #5239

@lizayugabyte
Copy link
Contributor

@ddorian What about "Presplit tablets remain in the system forever and are not deleted from the disk" ?

@ddorian
Copy link
Contributor Author

ddorian commented Jan 26, 2021

What about "Presplit tablets remain in the system forever and are not deleted from the disk" ?

I think it's done in #4929 cc @ttyusupov ?

@lizayugabyte lizayugabyte moved this from In progress to Needs Tech Input in Documentation Jan 26, 2021
@ttyusupov
Copy link
Contributor

I've updated related docs. Feel free to close this issue if you think #7004 resolved it.

@lizayugabyte
Copy link
Contributor

@ddorian @ttyusupov Okay, thanks, I'll leave the following 3 limitations that are listed in the updated architecture doc. Please confirm that I can close the ticket.

  • During tablet splitting, client applications may get an error from the driver and need to retry the request.
  • If tablet splitting occurs during an ongoing distributed transaction, it could be aborted and need to be retried.
  • Since splitting of tablets that are not completely compacted is not yet implemented, tablets created by tablet splitting might be split after they reach the specified size threshold.

@lizayugabyte lizayugabyte linked a pull request Jan 28, 2021 that will close this issue
@lizayugabyte lizayugabyte moved this from Needs Tech Input to In review in Documentation Jan 28, 2021
@lizayugabyte lizayugabyte moved this from In review to Done in Documentation Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
Development

Successfully merging a pull request may close this issue.

4 participants