Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tablet splitting: cleanup split tablets #4929

Closed
ttyusupov opened this issue Jun 30, 2020 · 0 comments
Closed

Tablet splitting: cleanup split tablets #4929

ttyusupov opened this issue Jun 30, 2020 · 0 comments
Assignees
@ttyusupov
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature
Projects
Tablet splitting

Comments

@ttyusupov
Copy link
Contributor

ttyusupov commented Jun 30, 2020 •
edited by daniel-yb

  • Implement deleting tablet in state TABLET_DATA_SPLIT_COMPLETED after follower_unavailable_considered_failed_sec.
  • Add integration test for remote bootstrap from source split tablet before/after follower_unavailable_considered_failed_sec.
@ttyusupov ttyusupov created this issue from a note in Tablet splitting (To do) Jun 30, 2020
@ttyusupov ttyusupov added area/docdb YugabyteDB core features kind/new-feature This is a request for a completely new feature kind/enhancement This is an enhancement of an existing feature and removed kind/new-feature This is a request for a completely new feature labels Jun 30, 2020
@ttyusupov ttyusupov moved this from To do to In progress in Tablet splitting Jul 1, 2020
@ttyusupov ttyusupov self-assigned this Jul 1, 2020
@ttyusupov ttyusupov mentioned this issue Jul 27, 2020
Closed
ttyusupov added a commit that referenced this issue Sep 2, 2020
@ttyusupov
#5230: Track last applied operation ID
1682abc 
Summary:
We need to track the last applied operation ID in order to decide when it is safe to clean up the tablet after it has been split (#4929).

- Added tracking of last applied operation ID
- Added tracking of last operation ID applied by all tracked peers
- Updates consensus-related tests
- Added QLTabletTest.LastAppliedOpIdTracking

Test Plan:
```
ybd --gtest_filter QLTabletTest.LastAppliedOpIdTracking
```

Reviewers: mikhail, sergei, bogdan

Reviewed By: sergei

Subscribers: ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D9059
@ttyusupov ttyusupov mentioned this issue Sep 25, 2020
Closed
@ttyusupov ttyusupov moved this from In progress to Review in Tablet splitting Sep 25, 2020
ttyusupov added a commit that referenced this issue Oct 4, 2020
@ttyusupov
#4929: Cleanup split tablets
ee13d1e 
Summary:
Implemented cleanup of the tablet for which all replicas have been split:
- Added DeleteTablet master functionality and RPC support.
- Renamed `TEST_GetAllAppliedOpId` -> `GetAllAppliedOpId` to be used in production code.
- `TSTabletManager`: added tablets cleaner background task which is responsible for deleting of split tablets that are no longer needed.
- Added `TabletSplitITest.ParentTabletCleanup`.

Test Plan:
```
ybd --remote --dltp --cxx-test tablet-split-itest -n 100 -- -p 1
```

Reviewers: hector, nicolas, bogdan

Reviewed By: bogdan

Subscribers: zyu, ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D9456
Tablet splitting automation moved this from Review to Done Oct 4, 2020
@bmatican bmatican mentioned this issue Jan 21, 2021
Closed
@ddorian ddorian mentioned this issue Jan 26, 2021
Closed
@ryan-ally ryan-ally mentioned this issue Nov 28, 2023
Open
@nyndyny nyndyny mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttyusupov ttyusupov

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature
Projects
Tablet splitting
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ttyusupov