Write RPC should take into account retryable_rpc_single_call_timeout_ms #932
Assignees
Labels
kind/bug
This issue is a bug
Comments
yugabyte-ci
pushed a commit
that referenced
this issue
Mar 8, 2019
…le_call_timeout_ms Summary: Write RPC does ignores value of retryable_rpc_single_call_timeout_ms flag for single RPC call. It uses overall operation timeout. That causes issues, when initial request was sent to node that lost leadership during network partition. Fixed by using retryable_rpc_single_call_timeout_ms for single RPC timeout calculation. Also added flag combine_batcher_errors, so batcher would return actual error instead of IOError. It simplifies writing tests. Test Plan: ybd --cxx-test ql-stress-test --gtest_filter QLStressTest.NetworkPartition Reviewers: timur, amitanand, mikhail Reviewed By: mikhail Subscribers: bogdan, ybase, bharat Differential Revision: https://phabricator.dev.yugabyte.com/D6228
mbautin
pushed a commit
that referenced
this issue
Jul 11, 2019
…ed to the earlier commit af4cec4 Original commit message: ENG-4725: #932: Write RPC should take into account retryable_rpc_single_call_timeout_ms Summary: Write RPC does ignores value of retryable_rpc_single_call_timeout_ms flag for single RPC call. It uses overall operation timeout. That causes issues, when initial request was sent to node that lost leadership during network partition. Fixed by using retryable_rpc_single_call_timeout_ms for single RPC timeout calculation. Also added flag combine_batcher_errors, so batcher would return actual error instead of IOError. It simplifies writing tests. Test Plan: ybd --cxx-test ql-stress-test --gtest_filter QLStressTest.NetworkPartition Reviewers: timur, amitanand, mikhail Reviewed By: mikhail Subscribers: bogdan, ybase, bharat Differential Revision: https://phabricator.dev.yugabyte.com/D6228
mbautin
pushed a commit
to mbautin/yugabyte-db
that referenced
this issue
Jul 16, 2019
…rpc_single_call_timeout_ms Summary: Write RPC does ignores value of retryable_rpc_single_call_timeout_ms flag for single RPC call. It uses overall operation timeout. That causes issues, when initial request was sent to node that lost leadership during network partition. Fixed by using retryable_rpc_single_call_timeout_ms for single RPC timeout calculation. Also added flag combine_batcher_errors, so batcher would return actual error instead of IOError. It simplifies writing tests. Test Plan: ybd --cxx-test ql-stress-test --gtest_filter QLStressTest.NetworkPartition Reviewers: timur, amitanand, mikhail Reviewed By: mikhail Subscribers: bogdan, ybase, bharat Differential Revision: https://phabricator.dev.yugabyte.com/D6228 Note: This commit provides additional functionality that is logically related to the earlier commit yugabyte@af4cec4 and supersedes the commit yugabyte@b319d36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Write RPC does ignores value of retryable_rpc_single_call_timeout_ms flag for single RPC call.
It uses overall operation timeout. That causes issues, when initial request was sent to node that lost leadership during network partition.
The text was updated successfully, but these errors were encountered: