Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] create a new contributors' guide #11669

Merged
merged 24 commits into from
May 21, 2022

Conversation

polarweasel
Copy link
Contributor

@polarweasel polarweasel commented Mar 5, 2022

@netlify /latest/contribute/docs/

Notes:

  • syntax diagram section is ripped straight out of the readme, and needs cleanup
  • added a link to the Contribute dropdown

@netlify
Copy link

netlify bot commented Mar 5, 2022

✔️ Deploy Preview for infallible-bardeen-164bc9 ready!

🔨 Explore the source changes: b885dbb

🔍 Inspect the deploy log: https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/6222cece88d61a00076fb99e

😎 Browse the preview: https://deploy-preview-11669--infallible-bardeen-164bc9.netlify.app/latest/contribute/docs/

@netlify
Copy link

netlify bot commented Mar 5, 2022

Deploy Preview for infallible-bardeen-164bc9 ready!

Name Link
🔨 Latest commit d101cf4
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/628830a95804600008ccd0d3
😎 Deploy Preview https://deploy-preview-11669--infallible-bardeen-164bc9.netlify.app/latest/contribute/docs/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@lizayugabyte lizayugabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started making comments, but then stopped.
I assume the contributors will treat this doc as a style guide of sorts. I suggest that we follow conventions (e.g. when to use different fonts, how to introduce lists, etc.)
Feel free to reassign me the ticket.

docs/content/latest/contribute/_index.md Outdated Show resolved Hide resolved
docs/content/latest/contribute/_index.md Outdated Show resolved Hide resolved
docs/content/latest/contribute/docs/_index.md Outdated Show resolved Hide resolved
docs/content/latest/contribute/docs/_index.md Outdated Show resolved Hide resolved
docs/content/latest/contribute/docs/docs-build.md Outdated Show resolved Hide resolved
docs/content/latest/contribute/docs/_index.md Outdated Show resolved Hide resolved
docs/content/latest/contribute/docs/docs-layout.md Outdated Show resolved Hide resolved
```

1. Commit your changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent this code block more

docs/content/latest/contribute/docs/docs-checklist.md Outdated Show resolved Hide resolved
docs/content/latest/contribute/docs/docs-checklist.md Outdated Show resolved Hide resolved
@@ -50,25 +66,21 @@ menu:
| `showAsideToc` | `false` | Should the TOC on the right be enabled |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| isTocNested | false | Should sub-sections be displayed in the TOC on the right. Set to true. (Content pages only) |


# Widgets
## Widgets

There are a number of display widgets available. These are listed below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortcuts

{{<support-cloud>}} - link to Yugabyte Support form, cloud topic.

and any others


Content pages contain information about topics. The names of these docs page has the format `my-docs-page.md`.
**Content pages** contain information about topics. These pages are named in the format `my-docs-page.md`.

Copy link
Contributor

@ddhodge ddhodge Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links

Make links relative.

Links to pages end in a forward slash (/) and do not include the file suffix.

[Security checklist](../../secure/security-checklist/)

Links to anchors inside pages do not end in a forward slash (/), but note the forward slash that precedes the anchor.

[Limit network exposure](../../secure/security-checklist/#limit-network-exposure)

docs/content/latest/contribute/docs/docs-style.md Outdated Show resolved Hide resolved
docs/content/latest/contribute/docs/docs-style.md Outdated Show resolved Hide resolved
showAsideToc: true
---

In this kind of work, the nature of your documentation change means that you'll need to modify existing [_syntax diagrams_](#syntax-diagram) or add new ones.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this kind of work, the nature of your documentation change means that you'll need to modify existing [_syntax diagrams_](#syntax-diagram) or add new ones.
The API documentation uses [_syntax diagrams_](#syntax-diagram). The following describes diagram maintenance and creation for the YSQL API documentation. (The YCQL documentation uses an old method for syntax diagrams; take advice from colleagues if you need to work on YCQL diagrams.)


In this kind of work, the nature of your documentation change means that you'll need to modify existing [_syntax diagrams_](#syntax-diagram) or add new ones.

> **Note:** The following covers diagram maintenance and creation for the YSQL documentation. The YCQL documentation still uses an old method for this. You must take advice from colleagues if you need to work on YCQL diagrams.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Note:** The following covers diagram maintenance and creation for the YSQL documentation. The YCQL documentation still uses an old method for this. You must take advice from colleagues if you need to work on YCQL diagrams.


Here is a terse step-by-step summary:

### Get set up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Get set up
## Get set up


1. [_Run the generator_](#run-the-generator). This will regenerate every diagram file that is jointly specified by the [_diagram definition file_](#diagram-definition-file) and the set of all [_free-standing generated grammar-diagram pairs_](#free-standing-generated-grammar-diagram-pair). Of course, not all of these newly generated `md` files will differ from their previous versions; `git status` will show you only the ones that actually changed.

### Modify or add content pages or syntax rules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Modify or add content pages or syntax rules
## Modify or add content pages or syntax rules


> **Note:** There is no tool for link checking within your local git. Broken links are detected when a Yugabyte staff member periodically runs a link checker on the published doc on the Internet. The scope of this check includes _all_ of the Yugabyte properties (for example, the [Blogs site](https://blog.yugabyte.com)). Broken links that this check finds are reported and fixed manually.

## 3. Mental model and glossary: creating and maintaining syntax diagrams for YSQL Docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 3. Mental model and glossary: creating and maintaining syntax diagrams for YSQL Docs
## Mental model and glossary: creating and maintaining syntax diagrams for YSQL Docs


> **Note:** The following covers diagram maintenance and creation for the YSQL documentation. The YCQL documentation still uses an old method for this. You must take advice from colleagues if you need to work on YCQL diagrams.

Once you understand this area, modifying existing [_syntax diagrams_](#syntax-diagram) or adding new ones will seem to be very straightforward. However, you must embrace a fairly large mental model. This, in turn, depends on several terms of art. All this is covered in the dedicated section [Creating and maintaining syntax diagrams for YSQL Docs](#3-mental-model-and-glossary-creating-and-maintaining-syntax-diagrams-for-ysql-docs).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once you understand this area, modifying existing [_syntax diagrams_](#syntax-diagram) or adding new ones will seem to be very straightforward. However, you must embrace a fairly large mental model. This, in turn, depends on several terms of art. All this is covered in the dedicated section [Creating and maintaining syntax diagrams for YSQL Docs](#3-mental-model-and-glossary-creating-and-maintaining-syntax-diagrams-for-ysql-docs).
Once you understand this area, modifying existing [_syntax diagrams_](#syntax-diagram) or adding new ones will seem to be very straightforward. However, you must embrace a fairly large mental model. This, in turn, depends on several terms of art. All this is covered in the dedicated section [Creating and maintaining syntax diagrams for YSQL Docs](#mental-model-and-glossary-creating-and-maintaining-syntax-diagrams-for-ysql-docs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants