Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] updated ycsb commands #14024

Merged
merged 7 commits into from
Sep 16, 2022
Merged

Conversation

aishwarya24
Copy link
Collaborator

@aishwarya24 aishwarya24 commented Sep 15, 2022

resolves #14006
@mrajcevic01 , I have removed the maxexecutiontime as per your suggestion.

@netlify /preview/benchmark/ycsb-ysql/#6-run-individual-workloads-optional

  • Updated all the files with the note and general edits to maintain consistency in preview, stable, 2.12, and 2.8.

@aishwarya24 aishwarya24 added the area/documentation Documentation needed label Sep 15, 2022
@netlify
Copy link

netlify bot commented Sep 15, 2022

Deploy Preview for infallible-bardeen-164bc9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c598676
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/6324e26942f9c90009f18c8c
😎 Deploy Preview https://deploy-preview-14024--infallible-bardeen-164bc9.netlify.app/preview/benchmark/ycsb-ysql/#6-run-individual-workloads-optional
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@mrajcevic01 mrajcevic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you think we should still add a disclaimer about the fact that recordcount will need to match the number of rows in the table? Removing maxexecutiontime helps users avoid the issue but they can still run into it.

@aishwarya24
Copy link
Collaborator Author

@mrajcevic01 - Yes I have added it as well. Please let me know if this fine. Ill copy it to other files as well. Thanks!

Copy link
Contributor

@mrajcevic01 mrajcevic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put this note in the next section Run the workload as follows: since that is when the user would run into issues. During the load stage we are just inserting data. This note is specific to once the data has been loaded and before one of the actual workloads is run

@aishwarya24 aishwarya24 requested a review from ddhodge September 16, 2022 15:38
Copy link
Contributor

@ddhodge ddhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/content/preview/benchmark/ycsb-ysql.md Outdated Show resolved Hide resolved
docs/content/preview/benchmark/ycsb-ycql.md Outdated Show resolved Hide resolved
docs/content/preview/benchmark/ycsb-ycql.md Outdated Show resolved Hide resolved
docs/content/preview/benchmark/ycsb-ysql.md Outdated Show resolved Hide resolved
docs/content/preview/benchmark/ycsb-jdbc.md Outdated Show resolved Hide resolved
docs/content/preview/benchmark/ycsb-jdbc.md Outdated Show resolved Hide resolved
@aishwarya24 aishwarya24 merged commit e676889 into yugabyte:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] YCSB requires number of rows in usertable to be equal to recordcount parameter for successful run
3 participants