-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] updated ycsb commands #14024
[docs] updated ycsb commands #14024
Conversation
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do you think we should still add a disclaimer about the fact that recordcount will need to match the number of rows in the table? Removing maxexecutiontime helps users avoid the issue but they can still run into it.
@mrajcevic01 - Yes I have added it as well. Please let me know if this fine. Ill copy it to other files as well. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should put this note in the next section Run the workload as follows:
since that is when the user would run into issues. During the load stage we are just inserting data. This note is specific to once the data has been loaded and before one of the actual workloads is run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
resolves #14006
@mrajcevic01 , I have removed the
maxexecutiontime
as per your suggestion.@netlify /preview/benchmark/ycsb-ysql/#6-run-individual-workloads-optional