Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] use docsy's new readfile shortcode #14425

Closed
wants to merge 5 commits into from

Conversation

polarweasel
Copy link
Contributor

@polarweasel polarweasel commented Oct 12, 2022

This is a temporary fix until Docsy 0.5.0 lands.

@netlify /preview/tabpane-include/

@polarweasel polarweasel added the area/documentation Documentation needed label Oct 12, 2022
@polarweasel
Copy link
Contributor Author

Hey @ddhodge I've added Docsy 0.5.0's readfile shortcode here. Want to play around and see if it's fixed the inclusion problem with tabpanes?

@netlify
Copy link

netlify bot commented Oct 12, 2022

Deploy Preview for infallible-bardeen-164bc9 ready!

Name Link
🔨 Latest commit 838deb0
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/635041b1eb2e47000772c7ad
😎 Deploy Preview https://deploy-preview-14425--infallible-bardeen-164bc9.netlify.app/preview/tabpane-include
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@polarweasel
Copy link
Contributor Author

As of fc65836, tabpane inclusions render now, but the behaviour of the tabs and their content is weird. One pane's tabs will switch, but the other pane's tabs won't. I think it's the first one you click. But then clicking the second pane's tabs will switch the first pane's content, but not its tab headers.

@polarweasel
Copy link
Contributor Author

Fixed in Docsy 0.5.1, which we're now using on the live site. No need for this PR.

@polarweasel polarweasel deleted the docs-fix-readfile branch October 31, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant