Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update GORM Docs to reflect the latest changes in the Gorm orm-examples application #21900

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

Sfurti-yb
Copy link
Contributor

The Gorm orm-example was recently updated(PR) to use latest go functionality and smart driver. I have updated the docs to reflect these changes as well. Please take a look and let me know in case of any queries. Thanks!

@Sfurti-yb Sfurti-yb added the area/documentation Documentation needed label Apr 10, 2024
@Sfurti-yb Sfurti-yb self-assigned this Apr 10, 2024
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for infallible-bardeen-164bc9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 272d0c0
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/661ecfd82d181800083e5a82
😎 Deploy Preview https://deploy-preview-21900--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

* Update pgx driver version from v4 to v5 in docs.
Copy link
Collaborator

@aishwarya24 aishwarya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments.

docs/content/stable/drivers-orms/go/yb-pgx.md Show resolved Hide resolved
docs/content/preview/drivers-orms/orms/go/ysql-gorm.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ddhodge ddhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -112,13 +103,13 @@ Create 2 orders.

```sh
$ curl \
--data '{ "userId": "2", "products": [ { "productId": 1, "units": 2 } ] }' \
--data '{ "userId": 2, "products": [ { "productId": 1, "units": 2 } ] }' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sfurti-yb - can you clarify ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddhodge it could be, we will have to test the individual applications to check if this fix is needed for any of them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wouldn't all the examples regardless of driver use the same REST syntax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand, each ORM has a different way of parsing the message body, and some might not throw an error in this case. This needs to be verified with the individual ORM application to check how message bodies are being handled internally. Maybe create a ticket to verify this behaviour

@aishwarya24 aishwarya24 merged commit 95ec08a into yugabyte:master Apr 30, 2024
2 checks passed
svarnau pushed a commit that referenced this pull request May 25, 2024
…-examples application (#21900)

* Upgrade the gorm docs to use latest go version and gorm v2

* Mentioned the use of smart drivers

* Harsh daryani896 patch 1 (#2)

* Update pgx driver version from v4 to v5 in docs.

* review comments and copied to preview

---------

Co-authored-by: Harsh Daryani <82017686+HarshDaryani896@users.noreply.github.com>
Co-authored-by: aishwarya24 <ashchakravarthy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants