-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update GORM Docs to reflect the latest changes in the Gorm orm-examples application #21900
Conversation
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
* Update pgx driver version from v4 to v5 in docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -112,13 +103,13 @@ Create 2 orders. | |||
|
|||
```sh | |||
$ curl \ | |||
--data '{ "userId": "2", "products": [ { "productId": 1, "units": 2 } ] }' \ | |||
--data '{ "userId": 2, "products": [ { "productId": 1, "units": 2 } ] }' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this fix needed for all the examples
eg
https://deploy-preview-21900--infallible-bardeen-164bc9.netlify.app/stable/drivers-orms/orms/python/ysql-sqlalchemy/#send-requests-to-the-application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sfurti-yb - can you clarify ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddhodge it could be, we will have to test the individual applications to check if this fix is needed for any of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, wouldn't all the examples regardless of driver use the same REST syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand, each ORM has a different way of parsing the message body, and some might not throw an error in this case. This needs to be verified with the individual ORM application to check how message bodies are being handled internally. Maybe create a ticket to verify this behaviour
…-examples application (#21900) * Upgrade the gorm docs to use latest go version and gorm v2 * Mentioned the use of smart drivers * Harsh daryani896 patch 1 (#2) * Update pgx driver version from v4 to v5 in docs. * review comments and copied to preview --------- Co-authored-by: Harsh Daryani <82017686+HarshDaryani896@users.noreply.github.com> Co-authored-by: aishwarya24 <ashchakravarthy@gmail.com>
The Gorm orm-example was recently updated(PR) to use latest go functionality and smart driver. I have updated the docs to reflect these changes as well. Please take a look and let me know in case of any queries. Thanks!