[Loader]: Several bug fixes. #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
|
|
||
| // We cannot process this dependency yet if it must | ||
| // appear after our current module. | ||
| isntAfter = !trigger || (trigger.when && trigger.when !== "after"); |
There was a problem hiding this comment.
we should avoid negative variable names, I will propose insertAfter.
There was a problem hiding this comment.
that will also simplify the code.
|
Seems good. What introduced these bugs? |
|
Cool. Let's get these in then! |
This was referenced Apr 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
langpacks were not being included before the module itself.beforewas not working (see: [loader]beforein conditions is being ignored #1661).CSSmodule could not require ajsmodule. (see: http://jsbin.com/hafibawa/13/edit and CSS module loads out of order #1680).Updated five tests related to
langpacks that I erroneously changed in #1606.