when found.configfn return false, m is null

[mininice]

No description provided.

[yahoocla]

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

[okuryu]

I see m has a results of the this.addModule() above a few lines. What kind of situation are you have the problem?

[mininice]

function addModule has code like this， when ret === false， o = null， return null；

if (o.configFn) {
            ret = o.configFn(o);
            if (ret === false) {
                Y.log('Config function returned false for ' + name + ', skipping.', 'info', 'loader');
                delete this.moduleInfo[name];
                delete GLOBAL_ENV._renderedMods[name];
                o = null;
            }
}

[caridy]

found is always set when the module config is synthetically created based on a pattern, in which case addModule() will ALWAYS return a valid config. In other words, if found is valid, m will be valid to get a setting assigned to it.

[mininice]

example, I want to use patterns like this:

patterns : {
        "xxx-": {
               configFn: function(mod) {
                     //I don't want to load this mod, but don't want to use test
                     return false;
               }
       }
}

then, execute this code:

ret = o.configFn(o);
            if (ret === false) {
                Y.log('Config function returned false for ' + name + ', skipping.', 'info', 'loader');
                delete this.moduleInfo[name];
                delete GLOBAL_ENV._renderedMods[name];
                o = null;
            }

yui.js throw error, if code allow configFn return false，the after code should be compatible。

[yahoocla]

CLA is valid!

[caridy]

ah, that's a very edge case, jejejeje, but I see how you might want that. I will favor this PR, but you have to change it a little bit. Just re-use the existing if statement, like if (m && found.configFn)

[okuryu]

Updated the HISTORY.md in cdc5cc3.