-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart Axis Modularization #373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versions, add native versions, add meta tests, remove old references from polyfills
To be able to test which implementation is being used
…or scoping issue relevant to ticket).
…ons/references to the original global variable declaration rather than do it manually.
I'm not sure why this is broken on Travis, but this builds perfectly fine locally from a clean clone. |
thats a damn fine pull request description |
👍 Merge it.. |
@davglass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring of the chart's axis layer so that it is more modular. In this update, I've broken up the charts module into several smaller modules that can be downloaded as needed to build custom chart applications. For example, the below code snippet will only pull down code necessary to build a sparkline.
Despite the many diffs in this commit, there is not much actual code change. The vast bulk of diffs are API Doc updates so that one can view the propose breakout of charts modules by running yogi serve. Some diffs are due to code being moved into new classes for modularity. This is a work in progress (for this sprint) and the pull request is for the benefit of broadcasting the upcoming changes.
While any feedback is always welcome, the emphasis of this request is on the classes outlined in the attached diagrams and the new modules.
ORIGINAL AXIS CLASSES
UPDATED AXIS CLASSES
Also important are:
src/charts/build.json
src/charts/meta/*
Additionally, you can run yogi serve on the charts directory and click the API Docs link to get a good view of the modules.
The 'charts' and 'charts-legend' modules will have the same functionality as before.