Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote isn't rendered when put after list item #313

Closed
Gusted opened this issue Jul 6, 2022 · 0 comments
Closed

Quote isn't rendered when put after list item #313

Gusted opened this issue Jul 6, 2022 · 0 comments

Comments

@Gusted
Copy link

Gusted commented Jul 6, 2022

  1. What version of goldmark are you using? : v1.4.12
  2. What version of Go are you using? : go1.18.3
  3. What operating system and processor architecture are you using? :linux/amd64
  4. What did you do? : I tried to render 1.\n> This is a quote., via:
import (
        "bytes"
        "fmt"

        "github.com/yuin/goldmark"
)

func main() {
        md := goldmark.New()
        var buf bytes.Buffer
        if err := md.Convert([]byte("1.\n> This is a quote."), &buf); err != nil {
                panic(err)
        }
        fmt.Println(buf.String())
}
  1. What did you expect to see? :
<ol>
<li></li>
</ol>
<blockquote>
<p>This is a quote.</p>
</blockquote>
  1. What did you see instead? :
<ol>
<li></li>
</ol>
  1. Did you confirm your output is different from CommonMark online demo or other official renderer correspond with an extension?: Yes, the online demo does correctly render this.

  2. Additional info. If you put two newlines, it will correctly render, but it should also correctly render with one newline:

-         if err := md.Convert([]byte("1.\n> This is a quote."), &buf); err != nil {
+         if err := md.Convert([]byte("1.\n\n> This is a quote."), &buf); err != nil {
@yuin yuin closed this as completed in c085632 Jul 9, 2022
Gusted pushed a commit to Gusted/gitea that referenced this issue Jul 9, 2022
- Update goldmark to v1.4.13 to fix a issue with quotes after a empty
list item(See yuin/goldmark#313) and
downstream issue https://codeberg.org/Codeberg/Community/issues/645
Gusted pushed a commit to Gusted/gitea that referenced this issue Jul 9, 2022
- Backport go-gitea#20300
  - Update goldmark to v1.4.13 to fix a issue with quotes after a empty list item(See yuin/goldmark#313) and downstream issue https://codeberg.org/Codeberg/Community/issues/645
zeripath pushed a commit to go-gitea/gitea that referenced this issue Jul 9, 2022
Update goldmark to v1.4.13 to fix a issue with quotes after a empty
list item(See yuin/goldmark#313) and
downstream issue https://codeberg.org/Codeberg/Community/issues/645
zeripath pushed a commit to go-gitea/gitea that referenced this issue Jul 9, 2022
Backport #20300

  - Update goldmark to v1.4.13 to fix a issue with quotes after a empty list item(See yuin/goldmark#313) and downstream issue https://codeberg.org/Codeberg/Community/issues/645
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 10, 2022
Update goldmark to v1.4.13 to fix a issue with quotes after a empty
list item(See yuin/goldmark#313) and
downstream issue https://codeberg.org/Codeberg/Community/issues/645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant