testutil: Export ParseTestCaseFile #336
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts functionality from DoTestCaseFile
responsible for parsing test case files
into a ParseTestCases function.
The function is able to read from any io.Reader,
instead of being limited to just files.
A ParseTestCaseFile function is included for convenience.
The functions do not panic on errors--instead, they return the error.
While there, this updates DoTestCaseFile
so that it also does not panic on error,
and instead aborts the entire test instead.
Minor note about tests:
The tests for the parser use
reflect.DeepEqual
and%#v
.It would make for better error messages to use go-cmp
but I elected to not use that because so far,
goldmark has no third-party dependencies.
If you're open to the new dependency (only for test util),
I can make a separate PR for that in the future.